Resolvables #53
Merged
Resolvables #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perrygoy
reviewed
Feb 26, 2024
|
|
||
| def __init__(self) -> None: # pylint: disable=useless-super-delegation | ||
| super().__init__() | ||
| @beat("... hoping it's clickable") |
There was a problem hiding this comment.
I think these need punctuation at the end, i.e.
@beat("... hoping it's clickable.")There was a problem hiding this comment.
updated. I also somehow missed adding two tests for confirming these messages.
| assert annotation == "IsPresentElement" | ||
| assert type(ip.matcher) == IsPresentElement | ||
| assert type(ip.resolve()) == IsPresentElement |
There was a problem hiding this comment.
Don't we have a test_matches_protocols test that we run? Maybe that's just for Actions?
There was a problem hiding this comment.
Looks like we don't have those tests in screenpy for Resolutions, hm...
perrygoy
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Nice work, @bandophahita! Finally got these to follow the new standard. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #43