Implement ruff rules A through D #42
Conversation
setup.py
Outdated
There was a problem hiding this comment.
Do we still need this file anymore? Maybe this would be a good chance to delete it.
There was a problem hiding this comment.
I think we can remove it. I figured it's removal would be in it's own PR though. Since we need to do that for each of the packages.
|
@perrygoy updates are in. |
| @@ -52,40 +67,129 @@ selenium = ">=4.1.0" | |||
| importlib_metadata = {version = "*", python = "3.8.*"} | |||
|
|
|||
| # convenience packages for development of screenpy only | |||
| black = {version = "*", optional = true} | |||
| coverage = {version = "*", optional = true} | |||
| isort = {version = "*", optional = true} | |||
There was a problem hiding this comment.
Do we still need isort anymore? Doesn't ruff do the needful?
There was a problem hiding this comment.
Technically no.
I've still been using it until ruff implements the combine imports to single line feature. But otherwise no reason to have it in there still. I left it in because it only is installed for dev.
There was a problem hiding this comment.
All right, i don't really see a problem with it for now. 👍
| "coverage", | ||
| "isort", |
| @@ -52,40 +67,129 @@ selenium = ">=4.1.0" | |||
| importlib_metadata = {version = "*", python = "3.8.*"} | |||
|
|
|||
| # convenience packages for development of screenpy only | |||
| black = {version = "*", optional = true} | |||
| coverage = {version = "*", optional = true} | |||
| isort = {version = "*", optional = true} | |||
There was a problem hiding this comment.
All right, i don't really see a problem with it for now. 👍
No description provided.