Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing #40 - beat logging text should use single quotes #41

Merged
merged 1 commit into from
Mar 1, 2024
Merged

fixing #40 - beat logging text should use single quotes #41

merged 1 commit into from
Mar 1, 2024

Conversation

bandophahita
Copy link
Contributor

@bandophahita bandophahita commented Jan 10, 2024 •
edited
Loading

Addresses #40

@bandophahita bandophahita requested a review from perrygoy January 10, 2024 19:49
perrygoy
perrygoy previously approved these changes Feb 2, 2024
View reviewed changes
Copy link
Member

@perrygoy perrygoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, OK, let's make 'em singlequotes.

@bandophahita bandophahita marked this pull request as draft February 8, 2024 15:44
@bandophahita bandophahita force-pushed the issue_40 branch 2 times, most recently from 2884ea6 to cde8104 Compare February 22, 2024 00:12
@bandophahita bandophahita marked this pull request as ready for review February 26, 2024 20:13
perrygoy
perrygoy approved these changes Feb 26, 2024
View reviewed changes
Copy link
Member

@perrygoy perrygoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At long last, it's ready!

@bandophahita bandophahita merged commit 5c602c8 into ScreenPyHQ:trunk Mar 1, 2024
12 checks passed
@bandophahita bandophahita deleted the issue_40 branch March 1, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perrygoy perrygoy perrygoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bandophahita @perrygoy