Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project standardization #128

Merged
merged 21 commits into from
Feb 16, 2024

Conversation

bandophahita
Copy link
Contributor

#127
Attempting to make various portions of each screenpy project uniform.

@bandophahita bandophahita self-assigned this Feb 15, 2024
perrygoy
perrygoy previously approved these changes Feb 15, 2024
Copy link
Member

@perrygoy perrygoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nice cleanup in here! I had some small suggestions and comments.

docs/conf.py Outdated
Comment on lines 126 to 105
latex_elements = {
latex_elements: dict = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this file skipped by mypy?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is by default. I have a plugin that still lets me see the errors.

pyproject.toml Outdated Show resolved Hide resolved
screenpy/__version__.py Outdated Show resolved Hide resolved
screenpy/__version__.py Show resolved Hide resolved
perrygoy
perrygoy previously approved these changes Feb 16, 2024
Copy link
Member

@perrygoy perrygoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good! These look great to standardize against, thanks @bandophahita!

Copy link
Member

@perrygoy perrygoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A PR so nice, i approve it twice. 👍 👍

@bandophahita bandophahita merged commit 59dc96f into ScreenPyHQ:trunk Feb 16, 2024
11 checks passed
@bandophahita bandophahita deleted the project_standardization branch February 17, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants