SFD-98: Chart scaling on zoom bugfix

[jantoun-scottlogic]

SFD-98 Jira ticket

Scales the chart size with the browser zoom factor to fix a bug where the chart would become squashed when the browser zoom was increased.

Before fix:

After fix:

[mgriffin-scottlogic]

Just from a quick test of this myself, I'm still seeing an issue when it hits 400% zoom - I don't know if it's specific to my monitor resolution and scaling? (1920 x 1080 at 100%)

Haven't reviewed the code but I wonder if it could be falling prey to the opposite max height check if that's not also scaled with the zoom factor. There's a definite snap back to a small size as you get to 400:

300%

400%

[mgriffin-scottlogic]

And strangely it seems fine if I scroll to 500% very quickly, I assume the debounce means the 400% state is missed. But if I roll back and forth at that point then 500% will be broken too.

[jantoun-scottlogic]

Just from a quick test of this myself, I'm still seeing an issue when it hits 400% zoom - I don't know if it's specific to my monitor resolution and scaling? (1920 x 1080 at 100%)

Haven't reviewed the code but I wonder if it could be falling prey to the opposite max height check if that's not also scaled with the zoom factor. There's a definite snap back to a small size as you get to 400:

300%

400%

Ok thanks, I'll take a look. I was getting different degrees of 'squashedness' with the same zoom factor when trying to reproduce the bug so there's definitely something going on that I haven't pinned down. The scaling with zoom is applied after the screen height cap so hopefully that shouldn't be interfering.

[jantoun-scottlogic]

It looks like it's not scaling the chart if the screen is already zoomed when calculate is pressed either. It's not completely squashed for me but it's not as tall as it should be.

[sdun-scottlogic]

Tested & Approved.
*** Note** - Playwright device emulator and browser Dev Tools to recreate multiple device behaviour - used as a best endeavours alternative for testing. May not fully or accurately replicate each device but is accepted as a reasonable alternative for these test cases.