Migrate playwright tests to repo #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added info around running Playwright tests and getting the Estimator tool up and running.
Update to formatting.
Add some more content to ReadMe.
Updated playwright tests
mgriffin-scottlogic
requested review from
jantoun-scottlogic and
sdun-scottlogic
jantoun-scottlogic
requested changes
Jun 13, 2024
Co-authored-by: jantoun-scottlogic <[email protected]>
jantoun-scottlogic
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used git subtree command to bring @sdun-scottlogic's repo into playwright directory.
As far as I can understand this can be treated as a one time operation and we shouldn't need to depend on the source repo going forward.
There are now two new npm scripts,
playwright-installandplaywright-testto install the required python packages and run all tests respectively. This now also takes care of starting the server automatically and waiting for it to be ready before starting the tests.I was thinking that it would be good to get this merged in soon so that we can start fixing tests within this repo.