Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SFD-107: Change main pipeline to not publish from every commit #76

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

jantoun-scottlogic
Copy link
Contributor

SFD-107 Jira ticket

Removes the merge trigger for the pages deployment workflow leaving only the manual trigger.

Copy link
Collaborator

@mgriffin-scottlogic mgriffin-scottlogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, I think this can be merged in now?

I was going to suggest that workflow_dispatch should also be restricted to the main branch but apparently that's not a thing: https://stackoverflow.com/questions/72398993/github-action-workflow-dispatch-how-to-always-use-the-master-branch-remove-o

@jantoun-scottlogic
Copy link
Contributor Author

Approved, I think this can be merged in now?

I was going to suggest that workflow_dispatch should also be restricted to the main branch but apparently that's not a thing: https://stackoverflow.com/questions/72398993/github-action-workflow-dispatch-how-to-always-use-the-master-branch-remove-o

We could add a step at the start to check if the branch is main and exit if not.

@jantoun-scottlogic
Copy link
Contributor Author

Approved, I think this can be merged in now?
I was going to suggest that workflow_dispatch should also be restricted to the main branch but apparently that's not a thing: https://stackoverflow.com/questions/72398993/github-action-workflow-dispatch-how-to-always-use-the-master-branch-remove-o

We could add a step at the start to check if the branch is main and exit if not.

As discussed, we'll leave it as it is for now so people can publish from other branches if desired and revisit if needed.

@jantoun-scottlogic jantoun-scottlogic merged commit cb8101a into main Jun 13, 2024
2 checks passed
@jantoun-scottlogic jantoun-scottlogic deleted the SFD-107-make-publish-pipeline-manual-only branch June 13, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants