Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SFD-128: Add error summary for validation errors #118

Merged
merged 17 commits into from
Aug 5, 2024

Conversation

jantoun-scottlogic
Copy link
Contributor

@jantoun-scottlogic jantoun-scottlogic commented Jul 25, 2024

SFD-128 Jira ticket

Adds an error summary to display form validation errors. Includes links to the invalid input fields.

Notes:

  • The 'calculate' button was previously disabled when there were validation errors. It has been enabled at all times but the error summary will be shown if there are validation errors. This is so that the error feedback is the same whether the form is submitted using the 'enter' key or the 'calculate' button.

Error summary:
error-summary

Error summary dark mode:
error-summary-dark-mode

@jantoun-scottlogic jantoun-scottlogic force-pushed the SFD-128-submission-error-summary branch 2 times, most recently from 8da36cc to 55ab973 Compare July 25, 2024 10:30
@jantoun-scottlogic jantoun-scottlogic force-pushed the SFD-128-submission-error-summary branch from 55ab973 to 5e8eff4 Compare July 25, 2024 10:36
@jantoun-scottlogic jantoun-scottlogic marked this pull request as ready for review July 25, 2024 10:41
@jantoun-scottlogic jantoun-scottlogic force-pushed the SFD-128-submission-error-summary branch from b3c61e8 to 0b5b789 Compare July 29, 2024 14:43
@sdun-scottlogic
Copy link
Contributor

Tested & Approved - SD.

@jantoun-scottlogic jantoun-scottlogic merged commit f2cfaa3 into main Aug 5, 2024
3 checks passed
@jantoun-scottlogic jantoun-scottlogic deleted the SFD-128-submission-error-summary branch August 5, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants