Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SFD 152 Add tabular data #115

Merged
merged 37 commits into from
Aug 1, 2024
Merged

SFD 152 Add tabular data #115

merged 37 commits into from
Aug 1, 2024

Conversation

jmain-scottlogic
Copy link
Collaborator

@jmain-scottlogic jmain-scottlogic commented Jul 18, 2024

  • Create a table to give an alternative display for the emissions data. Table follows treegrid pattern, https://www.w3.org/WAI/ARIA/apg/patterns/treegrid/
  • Created a tab component
  • Refactored carbon estimation to have 2 tabs, one for graph data and one for tabular data

TODO

  • Confirm tab naming
    • Updated to Diagram and Table
  • Confirm table styling
  • Add placeholder for tabular data

@jmain-scottlogic
Copy link
Collaborator Author

Screen shot of the tab, with current names. Think the names could be better/clearer will make a post on teams to get clarity
image

@jmain-scottlogic
Copy link
Collaborator Author

Screen shot of the table.
image

@jantoun-scottlogic
Copy link
Contributor

Screen shot of the table. image

Looks great overall but would it be possible to align the headings with the content a bit more? In particular the 'Emissions' looks a bit off relative to the data in the column.

@jantoun-scottlogic
Copy link
Contributor

jantoun-scottlogic commented Jul 26, 2024

Screen shot of table placeholder image

I'm wondering if we should remove the expand/collapse arrow icons or make it so you can't click them and add the disabled mouseover icon to the placeholder since they don't expand or collapse sections when clicked. I'm not sure what's best here though, perhaps they should be left as they are.

@jmain-scottlogic
Copy link
Collaborator Author

Screen shot of table placeholder image

I'm wondering if we should remove the expand/collapse arrow icons or make it so you can't click them and add the disabled mouseover icon to the placeholder since they don't expand or collapse sections when clicked. I'm not sure what's best here though, perhaps they should be left as they are.

Have removed the placeholder and added some text that say No estimation available. As realised didnt need a placeholder for a table

@jmain-scottlogic
Copy link
Collaborator Author

New empty table screenshot
image

@jmain-scottlogic
Copy link
Collaborator Author

Tab names have been updated to Diagram and Table.

@sdun-scottlogic
Copy link
Contributor

Tested & Approved - SD.

@jmain-scottlogic jmain-scottlogic merged commit af097a4 into main Aug 1, 2024
3 checks passed
@jmain-scottlogic jmain-scottlogic deleted the SFD-152-tabular-data branch August 1, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants