Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

714: Show error is we fail to reset defences #927

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

714: Show error is we fail to reset defences #927

wants to merge 3 commits into from

Conversation

calummcgowan
Copy link

@calummcgowan calummcgowan commented Nov 4, 2024 •
edited
Loading

Description

Screenshots

Screenshot 2024-11-04 110448

Notes

  • Changes made to MainComponent.tsx: add chat message when resetDefence fails
  • Changes to defenceService.ts: return null when DefenceResetResponse promise fails

Concerns

  • No unit tests added - may be irrelevant due to running only frontend

Checklist

Have you done the following?

  • Linked the relevant Issue
  • [] Added tests
  • Ensured the workflow steps are passing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show error if we fail to reset defences
1 participant
@calummcgowan