Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

913: Document Viewer improvements #916

Merged
merged 4 commits into from
Jul 15, 2024
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions backend/src/controller/documentController.ts

This file was deleted.

25 changes: 12 additions & 13 deletions backend/src/controller/levelController.ts
Original file line number Diff line number Diff line change
@@ -1,27 +1,26 @@
import { Response } from 'express';

import { getSandboxDocumentMetas } from '@src/document';
import { LevelGetRequest } from '@src/models/api/LevelGetRequest';
import { LEVEL_NAMES, isValidLevel } from '@src/models/level';
import { LEVEL_NAMES } from '@src/models/level';

function handleLoadLevel(req: LevelGetRequest, res: Response) {
const { level } = req.query;
import { validateLevel } from './requestValidators';

if (level === undefined) {
res.status(400).send('Level not provided');
return;
}
function handleLoadLevel(req: LevelGetRequest, res: Response) {
const level = validateLevel(res, req.query.level);
if (level === null) return;
Comment on lines +16 to +17
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this pattern


if (!isValidLevel(level)) {
res.status(400).send('Invalid level');
return;
}
const chatModel =
level === LEVEL_NAMES.SANDBOX ? req.session.chatModel : undefined;
const availableDocs =
level === LEVEL_NAMES.SANDBOX ? getSandboxDocumentMetas() : undefined;

res.send({
emails: req.session.levelState[level].sentEmails,
chatHistory: req.session.levelState[level].chatHistory,
defences: req.session.levelState[level].defences,
chatModel:
level === LEVEL_NAMES.SANDBOX ? req.session.chatModel : undefined,
chatModel,
availableDocs,
});
}

Expand Down
18 changes: 18 additions & 0 deletions backend/src/controller/requestValidators.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
import { Response } from 'express';

import { sendErrorResponse } from '@src/controller/handleError';
import { isValidLevel, LEVEL_NAMES } from '@src/models/level';

export function validateLevel(response: Response, level?: LEVEL_NAMES) {
if (level === undefined) {
sendErrorResponse(response, 400, 'Level not provided');
return null;
}

if (!isValidLevel(level)) {
sendErrorResponse(response, 400, 'Invalid level');
return null;
}

return level;
}
54 changes: 22 additions & 32 deletions backend/src/controller/resetController.ts
Original file line number Diff line number Diff line change
@@ -1,51 +1,41 @@
import { Response } from 'express';

import { LevelGetRequest } from '@src/models/api/LevelGetRequest';
import { getSandboxDocumentMetas } from '@src/document';
import { LevelResetRequest } from '@src/models/api/LevelResetRequest';
import { ProgressResetRequest } from '@src/models/api/ProgressResetRequest';
import { defaultChatModel } from '@src/models/chat';
import { ChatInfoMessage } from '@src/models/chatMessage';
import {
LEVEL_NAMES,
getInitialLevelStates,
isValidLevel,
} from '@src/models/level';

function handleResetProgress(req: LevelGetRequest, res: Response) {
const { level } = req.query;

if (level === undefined) {
res.status(400).send('Level not provided');
return;
}

if (!isValidLevel(level)) {
res.status(400).send('Invalid level');
return;
}

console.debug('Resetting progress for all levels', req.session.levelState);
import { LEVEL_NAMES, getInitialLevelStates } from '@src/models/level';

import { validateLevel } from './requestValidators';

function handleResetProgress(req: ProgressResetRequest, res: Response) {
const level = validateLevel(res, req.query.level);
if (level === null) return;

console.debug('Resetting progress for all levels');
req.session.levelState = getInitialLevelStates();
req.session.chatModel = defaultChatModel;

const chatModel =
level === LEVEL_NAMES.SANDBOX ? req.session.chatModel : undefined;
const availableDocs =
level === LEVEL_NAMES.SANDBOX ? getSandboxDocumentMetas() : undefined;

res.send({
emails: req.session.levelState[level].sentEmails,
chatHistory: req.session.levelState[level].chatHistory,
defences: req.session.levelState[level].defences,
chatModel:
level === LEVEL_NAMES.SANDBOX ? req.session.chatModel : undefined,
chatModel,
availableDocs,
});
}

function handleResetLevel(req: LevelResetRequest, res: Response) {
const { level: levelStr } = req.params;

const level = Number(levelStr) as LEVEL_NAMES;

if (!isValidLevel(level)) {
res.status(400).send('Invalid level');
return;
}
const level = validateLevel(res, Number(req.params.level) as LEVEL_NAMES);
if (level === null) return;

console.debug('Resetting progress for level ', level);
console.debug(`Resetting progress for level ${level}`);
req.session.levelState[level].chatHistory = [];
req.session.levelState[level].sentEmails = [];
res.send({
Expand Down
26 changes: 11 additions & 15 deletions backend/src/controller/startController.ts
Original file line number Diff line number Diff line change
@@ -1,32 +1,28 @@
import { Response } from 'express';

import { getSandboxDocumentMetas } from '@src/document';
import {
StartGetRequest,
StartResponse,
} from '@src/models/api/StartGetRequest';
import { LEVEL_NAMES, isValidLevel } from '@src/models/level';
import { LEVEL_NAMES } from '@src/models/level';
import { getValidOpenAIModels } from '@src/openai';
import {
systemRoleLevel1,
systemRoleLevel2,
systemRoleLevel3,
} from '@src/promptTemplates';

import { sendErrorResponse } from './handleError';
import { validateLevel } from './requestValidators';

function handleStart(req: StartGetRequest, res: Response) {
const { level } = req.query;

if (level === undefined) {
sendErrorResponse(res, 400, 'Level not provided');
return;
}

if (!isValidLevel(level)) {
sendErrorResponse(res, 400, 'Invalid level');
return;
}
const level = validateLevel(res, req.query.level);
if (level === null) return;

const chatModel =
level === LEVEL_NAMES.SANDBOX ? req.session.chatModel : undefined;
const availableDocs =
level === LEVEL_NAMES.SANDBOX ? getSandboxDocumentMetas() : undefined;
const systemRoles = [
{ level: LEVEL_NAMES.LEVEL_1, systemRole: systemRoleLevel1 },
{ level: LEVEL_NAMES.LEVEL_2, systemRole: systemRoleLevel2 },
Expand All @@ -37,10 +33,10 @@ function handleStart(req: StartGetRequest, res: Response) {
emails: req.session.levelState[level].sentEmails,
chatHistory: req.session.levelState[level].chatHistory,
defences: req.session.levelState[level].defences,
chatModel,
availableDocs,
availableModels: getValidOpenAIModels(),
systemRoles,
chatModel:
level === LEVEL_NAMES.SANDBOX ? req.session.chatModel : undefined,
} as StartResponse);
}

Expand Down
15 changes: 6 additions & 9 deletions backend/src/document.ts
Original file line number Diff line number Diff line change
Expand Up @@ -58,19 +58,16 @@ function getSandboxDocumentMetas() {
return [...getDocumentMetas('common'), ...getDocumentMetas('sandbox')];
}

function getDocumentMetas(folder: string) {
function getDocumentMetas(folder: string): DocumentMeta[] {
const filepath = `resources/documents/${folder}`;
const documentMetas: DocumentMeta[] = [];

fs.readdirSync(filepath).forEach((file) => {
return fs.readdirSync(filepath).map((file) => {
const fileType = file.split('.').pop() ?? '';
documentMetas.push({
filename: file,
filetype: fileType === 'csv' ? 'text/csv' : fileType,
return {
fileName: file,
fileType: fileType === 'csv' ? 'text/csv' : fileType,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo fixes! This was causing redundant HEAD requests in the UI.

folder,
});
};
});
return documentMetas;
}

// store vectorised documents for each level as array
Expand Down
2 changes: 2 additions & 0 deletions backend/src/models/api/LevelGetRequest.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { Request } from 'express';
import { ChatModel } from '@src/models/chat';
import { ChatMessage } from '@src/models/chatMessage';
import { Defence } from '@src/models/defence';
import { DocumentMeta } from '@src/models/document';
import { EmailInfo } from '@src/models/email';
import { LEVEL_NAMES } from '@src/models/level';

Expand All @@ -13,6 +14,7 @@ export type LevelGetRequest = Request<
chatHistory: ChatMessage[];
defences: Defence[];
chatModel?: ChatModel;
availableDocs?: DocumentMeta[];
},
never,
{
Expand Down
23 changes: 23 additions & 0 deletions backend/src/models/api/ProgressResetRequest.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
import { Request } from 'express';

import { ChatModel } from '@src/models/chat';
import { ChatMessage } from '@src/models/chatMessage';
import { Defence } from '@src/models/defence';
import { DocumentMeta } from '@src/models/document';
import { EmailInfo } from '@src/models/email';
import { LEVEL_NAMES } from '@src/models/level';

export type ProgressResetRequest = Request<
never,
{
emails: EmailInfo[];
chatHistory: ChatMessage[];
defences?: Defence[];
chatModel?: ChatModel;
availableDocs?: DocumentMeta[];
},
never,
{
level?: LEVEL_NAMES;
}
>;
2 changes: 2 additions & 0 deletions backend/src/models/api/StartGetRequest.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { Request } from 'express';
import { ChatModel } from '@src/models/chat';
import { ChatMessage } from '@src/models/chatMessage';
import { Defence } from '@src/models/defence';
import { DocumentMeta } from '@src/models/document';
import { EmailInfo } from '@src/models/email';
import { LEVEL_NAMES } from '@src/models/level';

Expand All @@ -16,6 +17,7 @@ export type StartResponse = {
systemRole: string;
}[];
chatModel?: ChatModel;
availableDocs?: DocumentMeta[];
};

export type StartGetRequest = Request<
Expand Down
4 changes: 2 additions & 2 deletions backend/src/models/document.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ import { MemoryVectorStore } from 'langchain/vectorstores/memory';
import { LEVEL_NAMES } from './level';

interface DocumentMeta {
filename: string;
filetype: string;
fileName: string;
fileType: string;
folder: string;
}

Expand Down
10 changes: 7 additions & 3 deletions backend/src/server/nonSessionRoutes.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import express from 'express';
import { fileURLToPath } from 'node:url';

import { handleGetDocuments } from '@src/controller/documentController';
import { handleHealthCheck } from '@src/controller/healthController';

import { importMetaUrl } from './importMetaUtils';
Expand All @@ -11,8 +10,13 @@ export default express
.use(
'/documents',
express.static(
fileURLToPath(new URL('../../resources/documents', importMetaUrl()))
fileURLToPath(new URL('../../resources/documents', importMetaUrl())),
{
cacheControl: true,
maxAge: 604800000, // 7 days as millis
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documents rarely change, so we can tell the browser to cache them.

immutable: true,
index: false,
}
)
)
.get('/documents', handleGetDocuments)
.get('/health', handleHealthCheck);
5 changes: 0 additions & 5 deletions frontend/src/App.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { useCallback, useEffect, useRef, useState, JSX } from 'react';

import DocumentViewBox from './components/DocumentViewer/DocumentViewBox';
import MainComponent from './components/MainComponent/MainComponent';
import LevelsComplete from './components/Overlay/LevelsComplete';
import MissionInformation from './components/Overlay/MissionInformation';
Expand Down Expand Up @@ -98,9 +97,6 @@ function App() {
/>
);
}
function openDocumentViewer() {
openOverlay(<DocumentViewBox closeOverlay={closeOverlay} />);
}

// set the start level for a user who clicks beginner/expert
function setStartLevel(startLevel: LEVEL_NAMES) {
Expand All @@ -123,7 +119,6 @@ function App() {
numCompletedLevels={numCompletedLevels}
closeOverlay={closeOverlay}
updateNumCompletedLevels={updateNumCompletedLevels}
openDocumentViewer={openDocumentViewer}
openOverlay={openOverlay}
openInformationOverlay={openInformationOverlay}
openLevelsCompleteOverlay={openLevelsCompleteOverlay}
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/components/ChatBox/ChatBox.tsx
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import { Suspense, lazy, useEffect, useState } from 'react';

import { DEFAULT_DEFENCES } from '@src/Defences';
import '@src/components/ThemedButtons/ChatButton.css';
import LoadingButton from '@src/components/ThemedButtons/LoadingButton';
import ThemedButton from '@src/components/ThemedButtons/ThemedButton';
import { DEFAULT_DEFENCES } from '@src/defences';
import useUnitStepper from '@src/hooks/useUnitStepper';
import { ChatMessage, ChatResponse } from '@src/models/chat';
import { EmailInfo } from '@src/models/email';
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/components/ControlPanel/ControlPanel.tsx
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import { DEFENCES_HIDDEN_LEVEL3_IDS, MODEL_DEFENCES } from '@src/Defences';
import DefenceBox from '@src/components/DefenceBox/DefenceBox';
import ModelBox from '@src/components/ModelBox/ModelBox';
import DetailElement from '@src/components/ThemedButtons/DetailElement';
import ThemedButton from '@src/components/ThemedButtons/ThemedButton';
import { DEFENCES_HIDDEN_LEVEL3_IDS, MODEL_DEFENCES } from '@src/defences';
import { ChatMessage, ChatModel } from '@src/models/chat';
import {
DEFENCE_ID,
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/components/DefenceBox/DefenceBox.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { PROMPT_ENCLOSURE_DEFENCES } from '@src/Defences';
import { PROMPT_ENCLOSURE_DEFENCES } from '@src/defences';
import {
DEFENCE_ID,
DefenceConfigItem,
Expand Down
Loading