Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant docviewer button component #885

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

chriswilty
Copy link
Member

Description

There was some overly complex styling on the docviewer, and removing those uncovered that the component itself was unnecessary. Visually unchanged, but simpler code 👍

Screenshots

image

Checklist

Have you done the following?

  • Linked the relevant Issue no issue, quick fix
  • Added tests
  • Ensured the workflow steps are passing

@chriswilty chriswilty force-pushed the simplify-docviewer-button branch from dc908ba to 74f257b Compare March 28, 2024 14:07
Copy link
Contributor

@pmarsh-scottlogic pmarsh-scottlogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@chriswilty chriswilty merged commit c00b4ee into dev Mar 28, 2024
2 checks passed
@chriswilty chriswilty deleted the simplify-docviewer-button branch March 28, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants