824: bugfix for level queryparam #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriswilty
requested review from
pmarsh-scottlogic,
AAloshine-scottlogic and
dhinrichs-scottlogic
chriswilty
force-pushed
the
824-bugfix-level-queryparam
branch
2 times, most recently
from
22a3c10 to
2827013
Compare
chriswilty
force-pushed
the
824-bugfix-level-queryparam
branch
from
2827013 to
d486888
Compare
chriswilty
commented
Mar 5, 2024
| chatHistory: ChatMessage[]; | ||
| defences: Defence[]; | ||
| availableModels: string[]; | ||
| systemRoles: string[]; |
There was a problem hiding this comment.
Note this type was incorrect, now fixed.
pmarsh-scottlogic
approved these changes
Mar 5, 2024
chriswilty
added a commit
that referenced
this pull request
Apr 8, 2024
* Use query-types lib to parse request query params * API tests for start endpoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug in which the level param was not parsed into a number before checking, so the level endpoint always failed with 400 response.
Related to #824 and #842
Checklist
Have you done the following?