807: CDK auth stack (AWS Cognito) #818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriswilty
commented
Feb 5, 2024
| @@ -21,7 +21,18 @@ const tags = { | |||
| const generateStackName = stackName(app); | |||
| const generateDescription = resourceDescription(app); | |||
|
|
|||
| // Don't need this stack, yet... Or ever? Will ask Pete C. | |||
There was a problem hiding this comment.
Since confirmed, yes we will need it eventually!
chriswilty
force-pushed
the
385-cdk-fargate-loadbalancer
branch
from
1d7401b to
fcc6ae2
Compare
chriswilty
force-pushed
the
807-cdk-auth-stack
branch
2 times, most recently
from
d44aac0 to
bc7591c
Compare
pmarsh-scottlogic
approved these changes
Feb 13, 2024
Base automatically changed from
385-cdk-fargate-loadbalancer
to
feature/aws-cloud-infrastructure
February 13, 2024 16:28
chriswilty
force-pushed
the
807-cdk-auth-stack
branch
from
bc7591c to
841df76
Compare
chriswilty
added a commit
that referenced
this pull request
Feb 22, 2024
chriswilty
added a commit
that referenced
this pull request
Feb 29, 2024
chriswilty
added a commit
that referenced
this pull request
Mar 4, 2024
chriswilty
added a commit
that referenced
this pull request
Mar 8, 2024
chriswilty
added a commit
that referenced
this pull request
Mar 19, 2024
chriswilty
added a commit
that referenced
this pull request
Mar 21, 2024
chriswilty
added a commit
that referenced
this pull request
Mar 28, 2024
chriswilty
added a commit
that referenced
this pull request
Apr 11, 2024
chriswilty
added a commit
that referenced
this pull request
Apr 15, 2024
chriswilty
added a commit
that referenced
this pull request
Apr 24, 2024
chriswilty
added a commit
that referenced
this pull request
Apr 25, 2024
chriswilty
added a commit
that referenced
this pull request
Apr 29, 2024
chriswilty
added a commit
that referenced
this pull request
Jul 5, 2024
chriswilty
added a commit
that referenced
this pull request
Jul 15, 2024
chriswilty
added a commit
that referenced
this pull request
Jul 16, 2024
chriswilty
added a commit
that referenced
this pull request
Sep 25, 2024
chriswilty
added a commit
that referenced
this pull request
Sep 25, 2024
chriswilty
added a commit
that referenced
this pull request
Oct 22, 2024
chriswilty
added a commit
that referenced
this pull request
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cognito-based CDK auth stack.
Main parts of our Cognito resources are
UserPool- just as it sounds, defines a pool of users allowed to authenticate with our resourcesIdentityProvider- provides an integration with Azure AD, so that all ScottLogic users can gain access to the applicationUserPoolClient- determines how the userpool will be accessed, including the auth flow to use, any identity provider(s) to integrate with, and other stuff such as token lifetimesPrerequisite for #807 and #808
Concerns
I am adding this stack to the CDK app, even though it contains some commented-out code and the stack isn't even being deployed currently, because it was looking a touch tricky to extract it. I will shortly come to the auth stuff anyway, once the Route 53 domain-based stack is added.
Checklist
Have you done the following?