Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

level 1 story line #397

Merged
merged 4 commits into from
Oct 17, 2023
Merged

Conversation

heatherlogan-scottlogic
Copy link
Contributor

@heatherlogan-scottlogic heatherlogan-scottlogic commented Oct 17, 2023

Mission info (right now appears after welcome screen and when user clicks onto a level. Also is in the handbook but will be removed #395)
Displaying short mission info not included in this ticket but have added a parameter to the Levels information (missionInfoShort and missionInfoLong)

Image

Win condition:

spy-logic-chat-log-level-0.pdf

@heatherlogan-scottlogic heatherlogan-scottlogic linked an issue Oct 17, 2023 that may be closed by this pull request
3 tasks
@heatherlogan-scottlogic heatherlogan-scottlogic marked this pull request as ready for review October 17, 2023 11:39
@chriswilty
Copy link
Member

chriswilty commented Oct 17, 2023

Hmm, why is the win condition message right-aligned in that pdf? Is that the way it is in the UI as well, or just the pdf?

Edit: yeah just in the pdf. Let's pretend I didn't see that, for now.... 🤫

Copy link
Member

@chriswilty chriswilty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, checked it out and all good.

The merge conflict is a trivial one, an id changed to className in dev, but not in your changes.

backend/test/unit/email.test.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@gsproston-scottlogic gsproston-scottlogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just some minor things from me.

frontend/src/Levels.ts Outdated Show resolved Hide resolved
frontend/src/Levels.ts Outdated Show resolved Hide resolved
backend/src/email.ts Outdated Show resolved Hide resolved
@heatherlogan-scottlogic heatherlogan-scottlogic merged commit 129c022 into dev Oct 17, 2023
2 checks passed
@gsproston-scottlogic gsproston-scottlogic deleted the 381-level-1-story-adjustments branch October 18, 2023 14:13
chriswilty pushed a commit that referenced this pull request Apr 8, 2024
* level 1 story line

* update tests

* fix typos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Level 1 Story adjustments
3 participants