-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
level 1 story line #397
level 1 story line #397
Conversation
Hmm, why is the win condition message right-aligned in that pdf? Is that the way it is in the UI as well, or just the pdf? Edit: yeah just in the pdf. Let's pretend I didn't see that, for now.... 🤫 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me, checked it out and all good.
The merge conflict is a trivial one, an id changed to className in dev, but not in your changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just some minor things from me.
* level 1 story line * update tests * fix typos
Mission info (right now appears after welcome screen and when user clicks onto a level. Also is in the handbook but will be removed #395)
Displaying short mission info not included in this ticket but have added a parameter to the Levels information (missionInfoShort and missionInfoLong)
Win condition:
spy-logic-chat-log-level-0.pdf