Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update JumpSystem for auto-alg support #2931

Merged
merged 6 commits into from
Aug 7, 2024

Conversation

isaacsas
Copy link
Member

@isaacsas isaacsas commented Aug 6, 2024

This enables JumpProblem(::JumpSystem, ::DiscreteProblem), i.e. eliminating the requirement to pass an aggregator, and using the new auto-alg in JumpProcesses.

@isaacsas isaacsas changed the title [WIP] - update JumpSystem for auto-alg support update JumpSystem for auto-alg support Aug 6, 2024
@isaacsas isaacsas closed this Aug 6, 2024
@isaacsas isaacsas reopened this Aug 6, 2024
@isaacsas
Copy link
Member Author

isaacsas commented Aug 6, 2024

@ChrisRackauckas I think this is good to go. (And it would be great for finishing this off in Catalyst if there can be a MTK release with it once merged.) Thanks!

@isaacsas isaacsas changed the title update JumpSystem for auto-alg support [WIP] - update JumpSystem for auto-alg support Aug 6, 2024
@isaacsas
Copy link
Member Author

isaacsas commented Aug 6, 2024

Strike that, this needs a tweak to ensure it generates dependency graphs when appropriate.

@isaacsas isaacsas closed this Aug 6, 2024
@isaacsas isaacsas reopened this Aug 6, 2024
@isaacsas isaacsas changed the title [WIP] - update JumpSystem for auto-alg support update JumpSystem for auto-alg support Aug 6, 2024
@isaacsas
Copy link
Member Author

isaacsas commented Aug 6, 2024

Ok, now this should be good to go.

@ChrisRackauckas ChrisRackauckas merged commit 3f7ad46 into SciML:master Aug 7, 2024
26 of 46 checks passed
@isaacsas isaacsas deleted the auto_alg_jsys_support branch August 7, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants