Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Array paramter scoping #2352

Closed
wants to merge 4 commits into from
Closed

Array paramter scoping #2352

wants to merge 4 commits into from

Conversation

contradict
Copy link
Contributor

This patch requires Symbolics.jl#1010 to ensure metadata is preserved across the scalarize call.

This fixes #2252.

@contradict contradict mentioned this pull request Nov 12, 2023
Closed
@contradict
Copy link
Contributor Author

Since Symbolics.scalarize may drop metadata, this approach won't work. I think it is possible to turn ParentScope(x[1]) into ParentScope(x)[1] which has a better chance of surviving long enough to be used. I'm going to close this PR and try another one with that approach.

@contradict contradict closed this Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Array parameters are not correctly scoped with ParentScope
1 participant
@contradict