Fix saveat plotting #430
Merged
Fix saveat plotting #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacsas
commented
Jul 25, 2024
test/save_positions.jl
Outdated
Comment on lines
51
to
57
| oprob = ODEProblem((du,u,p,t) -> du[1] = .1, u0, tspan) | ||
| for sp in sps | ||
| jprob = JumpProblem(oprob, Direct(), crj; save_positions = sp, rng) | ||
| sol = solve(jprob, Tsit5()) | ||
| @test sol.dense == true | ||
| @test SciMLBase.isdenseplot(sol) == true | ||
| end |
There was a problem hiding this comment.
Currently with PDMPs or jump-diffusions sol.dense == true always, irregardless of save_positions. I'm not sure if this should be considered an issue or not.
ChrisRackauckas
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This preserves using piecewise constant plotting when saving every jump, but switches to less misleading linear interpolation when not saving every jump.
Requires SciML/SciMLBase.jl#749
Closes #206