Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test master #424

Closed
wants to merge 1 commit into from
Closed

Test master #424

wants to merge 1 commit into from

Conversation

ChrisRackauckas
Copy link
Member

No description provided.

@ChrisRackauckas
Copy link
Member Author

@oscardssmith you've been looking at this recently, is this the same FastBroadcast change?

@oscardssmith
Copy link
Contributor

looks like it. It's weird that the OrdinaryDiffEq tests didn't find this though. I'll investigate.

@oscardssmith
Copy link
Contributor

oh, this is much worse than the other instances of this issue. For some reason linres.u is length 3, but u and k1 are length 1. How did this ever work?

@ChrisRackauckas
Copy link
Member Author

This array type acts like x.u but then has extra x.jump_u that are kept along for broadcast. It's a very weird array. Maybe its FastBroadcast extension should just opt-out so it can use its broadcast overloads.

@oscardssmith
Copy link
Contributor

oh this is fun. It turns out that [email protected] just works without the extension, but the extension breaks it.

@isaacsas isaacsas closed this Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChrisRackauckas @oscardssmith @isaacsas