Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "create dataset privileged" groups and review dataset authorization #818

Merged
merged 248 commits into from
Nov 22, 2023
Merged

Add "create dataset privileged" groups and review dataset authorization #818

merged 248 commits into from
Nov 22, 2023

Conversation

nitrosx
Copy link
Contributor

@nitrosx nitrosx commented Oct 17, 2023

This PR adds a configuration group that allows users to be able to create datasets for other groups (ingestion) and implement the correct dataset authorization.

Tests included/Docs Updated?

  • Included for each change/fix?
  • Passing? (Merge will not be approved unless this is checked)
  • Docs updated?
  • New packages used/requires npm install?
  • Toggle added for new features?

nitrosx and others added 30 commits October 17, 2023 13:56
@nitrosx
wip, still needs to be completed and tested
40a5153
@nitrosx
Updated casl factory according to latest authorization table for sub-…
c9a1e04 
…systems: datasets, origdatablock and jobs
@nitrosx
done refactoring dataset authorization. Still need testing
f1623dc
@nitrosx
fixed job class name. fixed linting issues in casl factory
201c389
@nitrosx
fixed linting issues. starting test fixing
5914169
@nitrosx
FIxed all linting, started testing DatasetAuthorization
ee857f3
@nitrosx
added functional accounts example and test files
eab4629
@dependabot @Junjiequan
build(deps-dev): bump @types/supertest from 2.0.13 to 2.0.14
1f31079 
Bumps [@types/supertest](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/supertest) from 2.0.13 to 2.0.14.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/supertest)

---
updated-dependencies:
- dependency-name: "@types/supertest"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @Junjiequan
build(deps-dev): bump eslint from 8.50.0 to 8.51.0
c734778 
Bumps [eslint](https://github.com/eslint/eslint) from 8.50.0 to 8.51.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](eslint/eslint@v8.50.0...v8.51.0)

---
updated-dependencies:
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @Junjiequan
build(deps-dev): bump @types/node from 20.8.0 to 20.8.3
1e17a26 
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 20.8.0 to 20.8.3.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @Junjiequan
build(deps): bump openid-client from 5.5.0 to 5.6.0
1eb5bea 
Bumps [openid-client](https://github.com/panva/node-openid-client) from 5.5.0 to 5.6.0.
- [Release notes](https://github.com/panva/node-openid-client/releases)
- [Changelog](https://github.com/panva/node-openid-client/blob/main/CHANGELOG.md)
- [Commits](panva/openid-client@v5.5.0...v5.6.0)

---
updated-dependencies:
- dependency-name: openid-client
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @Junjiequan
build(deps): bump mongoose from 7.5.3 to 7.6.0
4a4bdfc 
Bumps [mongoose](https://github.com/Automattic/mongoose) from 7.5.3 to 7.6.0.
- [Release notes](https://github.com/Automattic/mongoose/releases)
- [Changelog](https://github.com/Automattic/mongoose/blob/master/CHANGELOG.md)
- [Commits](Automattic/mongoose@7.5.3...7.6.0)

---
updated-dependencies:
- dependency-name: mongoose
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @Junjiequan
build(deps-dev): bump @typescript-eslint/parser from 6.7.3 to 6.7.4
cb2fb76 
Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 6.7.3 to 6.7.4.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.7.4/packages/parser)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/parser"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @Junjiequan
build(deps): bump nodemailer from 6.9.5 to 6.9.6
1ab3c8b 
Bumps [nodemailer](https://github.com/nodemailer/nodemailer) from 6.9.5 to 6.9.6.
- [Release notes](https://github.com/nodemailer/nodemailer/releases)
- [Changelog](https://github.com/nodemailer/nodemailer/blob/master/CHANGELOG.md)
- [Commits](nodemailer/nodemailer@v6.9.5...v6.9.6)

---
updated-dependencies:
- dependency-name: nodemailer
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @Junjiequan
build(deps-dev): bump ts-loader from 9.4.4 to 9.5.0
5a91cfb 
Bumps [ts-loader](https://github.com/TypeStrong/ts-loader) from 9.4.4 to 9.5.0.
- [Release notes](https://github.com/TypeStrong/ts-loader/releases)
- [Changelog](https://github.com/TypeStrong/ts-loader/blob/main/CHANGELOG.md)
- [Commits](TypeStrong/ts-loader@v9.4.4...v9.5.0)

---
updated-dependencies:
- dependency-name: ts-loader
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @Junjiequan
build(deps-dev): bump @typescript-eslint/eslint-plugin
b5b910e 
Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 6.7.3 to 6.7.4.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.7.4/packages/eslint-plugin)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/eslint-plugin"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @Junjiequan
build(deps-dev): bump sinon from 16.0.0 to 16.1.0
e119ae7 
Bumps [sinon](https://github.com/sinonjs/sinon) from 16.0.0 to 16.1.0.
- [Release notes](https://github.com/sinonjs/sinon/releases)
- [Changelog](https://github.com/sinonjs/sinon/blob/main/docs/changelog.md)
- [Commits](sinonjs/sinon@v16.0.0...v16.1.0)

---
updated-dependencies:
- dependency-name: sinon
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@Junjiequan
refactor: make createFullfacetPipeline more readable
b71d373
@Junjiequan
fix: minor note addition
bf52479
@Junjiequan
fix: eslint fix and removed comments
b278124
@dependabot @Junjiequan
build(deps-dev): bump @typescript-eslint/parser from 6.7.4 to 6.7.5
a1dadf9 
Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 6.7.4 to 6.7.5.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.7.5/packages/parser)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/parser"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @Junjiequan
build(deps-dev): bump @babel/traverse from 7.22.15 to 7.23.2
13b2ff6 
Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.22.15 to 7.23.2.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse)

---
updated-dependencies:
- dependency-name: "@babel/traverse"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @Junjiequan
build(deps): bump mongoose from 7.6.0 to 7.6.2
a71866c 
Bumps [mongoose](https://github.com/Automattic/mongoose) from 7.6.0 to 7.6.2.
- [Release notes](https://github.com/Automattic/mongoose/releases)
- [Changelog](https://github.com/Automattic/mongoose/blob/master/CHANGELOG.md)
- [Commits](Automattic/mongoose@7.6.0...7.6.2)

---
updated-dependencies:
- dependency-name: mongoose
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @Junjiequan
build(deps-dev): bump @faker-js/faker from 8.1.0 to 8.2.0
467603f 
Bumps [@faker-js/faker](https://github.com/faker-js/faker) from 8.1.0 to 8.2.0.
- [Release notes](https://github.com/faker-js/faker/releases)
- [Changelog](https://github.com/faker-js/faker/blob/next/CHANGELOG.md)
- [Commits](faker-js/faker@v8.1.0...v8.2.0)

---
updated-dependencies:
- dependency-name: "@faker-js/faker"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @Junjiequan
build(deps): bump @nestjs/swagger from 7.1.12 to 7.1.13
56d047f 
Bumps [@nestjs/swagger](https://github.com/nestjs/swagger) from 7.1.12 to 7.1.13.
- [Release notes](https://github.com/nestjs/swagger/releases)
- [Changelog](https://github.com/nestjs/swagger/blob/master/.release-it.json)
- [Commits](nestjs/swagger@7.1.12...7.1.13)

---
updated-dependencies:
- dependency-name: "@nestjs/swagger"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @Junjiequan
build(deps-dev): bump @types/uuid from 9.0.4 to 9.0.5
7913862 
Bumps [@types/uuid](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/uuid) from 9.0.4 to 9.0.5.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/uuid)

---
updated-dependencies:
- dependency-name: "@types/uuid"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @Junjiequan
build(deps-dev): bump @types/express from 4.17.18 to 4.17.19
4b6aafb 
Bumps [@types/express](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/express) from 4.17.18 to 4.17.19.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/express)

---
updated-dependencies:
- dependency-name: "@types/express"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @Junjiequan
build(deps-dev): bump @typescript-eslint/eslint-plugin
9cd9db4 
Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 6.7.4 to 6.7.5.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.7.5/packages/eslint-plugin)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/eslint-plugin"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @Junjiequan
build(deps): bump mathjs from 11.11.1 to 11.11.2
1835044 
Bumps [mathjs](https://github.com/josdejong/mathjs) from 11.11.1 to 11.11.2.
- [Changelog](https://github.com/josdejong/mathjs/blob/develop/HISTORY.md)
- [Commits](josdejong/mathjs@v11.11.1...v11.11.2)

---
updated-dependencies:
- dependency-name: mathjs
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @Junjiequan
build(deps): bump openid-client from 5.6.0 to 5.6.1
23b351d 
Bumps [openid-client](https://github.com/panva/node-openid-client) from 5.6.0 to 5.6.1.
- [Release notes](https://github.com/panva/node-openid-client/releases)
- [Changelog](https://github.com/panva/node-openid-client/blob/main/CHANGELOG.md)
- [Commits](panva/openid-client@v5.6.0...v5.6.1)

---
updated-dependencies:
- dependency-name: openid-client
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@Junjiequan
fix: DerivedDatasetDatablock test fixed
60d6a19
@Junjiequan
fix: partially improved origDatablocks authorization && DerivedDatase…
4b52dc8 
…tOrigDatablocks test fixed
@Junjiequan
fix: replaced instrument Action.delete with Action.InstrumentDelete
01bb37c
@Junjiequan
ignore - eslint format fix
30ee368
@Junjiequan
fix: added skip for Jobs test
5737d86
@Junjiequan
fix: OrigDatablockForRawDataset test fixed
c1a1a5b
@Junjiequan
fix: userAuthorization test fixed
1f2bf8d
@Junjiequan
fix: UserAuthorization test fixed -2
8854ded
@Junjiequan
fix: fixed test yaml env variables
00bb4a7
@Junjiequan
fix: update elasticSearch endpoint authorization
742b885
@Junjiequan
fix: RawDataset test fixed
f96e264
@Junjiequan
fix: added permission for proposal
ae0f2b2
@Junjiequan
fix: Proposal test fixed
e11c157
@Junjiequan
fix: added proposal groups env for the test
6cbba39
@Junjiequan
fix: proposalAuthentication test fixed
45fe1b2
@Junjiequan
fix: proposal test fixed 2
d9c9db5
@Junjiequan
fix: fixed all api test
6456787
@Junjiequan
fix: commented out e2e test
219682b
@Junjiequan
fix: DatasetLifecycle test fix
9d89445
nitrosx
nitrosx commented Nov 22, 2023
View reviewed changes
Copy link
Contributor Author

@nitrosx nitrosx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks really good. Nice work.

src/users/users.controller.ts Outdated Show resolved Hide resolved
test/CheckDifferentDatasetTypes.js Outdated Show resolved Hide resolved
nitrosx
nitrosx commented Nov 22, 2023
View reviewed changes
Copy link
Contributor Author

@nitrosx nitrosx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are ready to merge

@Junjiequan Junjiequan merged commit bee58dd into master Nov 22, 2023
7 checks passed
@Junjiequan Junjiequan deleted the issue-712 branch November 22, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Junjiequan Junjiequan Junjiequan left review comments

@bpedersen2 bpedersen2 bpedersen2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nitrosx @Junjiequan @bpedersen2 @martin-trajanovski