Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Spacing parameters for trackpy differently? #499

Open
Beno71 opened this issue Mar 10, 2024 · 1 comment
Open

Handle Spacing parameters for trackpy differently? #499

Beno71 opened this issue Mar 10, 2024 · 1 comment
Labels
🎈 Enhancement Enhancement to an existing feature

Comments

@Beno71
Copy link
Collaborator

Beno71 commented Mar 10, 2024

Description:

I stumbled accross an edge case when using trackpy in general.
When you have a file with PhysicalSizeX==PhysicalSizeY, trackpy will use pixel values to calculate distance. But when you have a 3D+time file and your PhysicalSizeZ is different, you might expect that the spacing attributes are used in tracking instead of pixels. However when you track on one z slice in 2D, pixel values will be used.
Maybe we could by default use the spacing attributes and also indicate that in the hyperparameter selection or introduce a switch to change between pixel values and using spacing attributes.

@Beno71 Beno71 added the 🎈 Enhancement Enhancement to an existing feature label Mar 10, 2024
@ElpadoCan
Copy link
Collaborator

ElpadoCan commented Mar 11, 2024

Hi @Beno71, you are right, thanks for spotting this.

I just fixed it in the latest release. I added a new parameter called Search range unit that can be either micrometre (default) or pixel (drop-down list). The selected unit will be used irrespective of whether physical sizes are equal or not.

I also changed the Neighbor strategy and the Link strategy parameters to drop-down lists as well (since only specific values are allowed).

Finally, I improved on the progress bar to show progress also for the loops before link_df is called.

Let me know if it works, thanks!

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎈 Enhancement Enhancement to an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants