Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Add points layer" function permanently changes mouse cursor #496

Open
Beno71 opened this issue Mar 9, 2024 · 1 comment
Open

"Add points layer" function permanently changes mouse cursor #496

Beno71 opened this issue Mar 9, 2024 · 1 comment
Labels
🐛 Bug Something isn't working

Comments

@Beno71
Copy link
Collaborator

Beno71 commented Mar 9, 2024

Description:

When you use the "Add points layer" functionality, even when you cancel it, the mouse cursor still looks like you'd be able to add points which is not the case. Even switching on another mode (e.g. brush) and off again, leaves you with the "add points" cursor.

Way to reproduce:

see description

(Optional) Link to data to reproduce error:

independent of data

Terminal output:

no error

Version information:

3.9.16 (main, Mar  8 2023, 10:39:24) [MSC v.1916 64 bit (AMD64)]
Windows-10-10.0.19045-SP0
Cell-ACDC version: 1.4.24rc2.dev1+g8c95b1d.d20240309
@Beno71 Beno71 added the 🐛 Bug Something isn't working label Mar 9, 2024
@ElpadoCan
Copy link
Collaborator

Hi @Beno71, thanks for spotting this!

I just fixed it in the latest version. I changed the implementation slightly. What was previously called Add points layer is now called Activate points layers and it's a checkable button that will show/hide the points layers toolbar. This way the add points cursor is visible only if the points layers button remains active.

To add a points layer, the Add points layer button has now been moved to the points layers toolbar. The only exception is when it is the first time that Activate points layers is pressed, because in that case acdc already asks to add a layer without having to press the add points layer button as well.

Let me know if it works, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants