Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/terraform plugin framework #11

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

benydc
Copy link

@benydc benydc commented May 31, 2022

  • add documentation (generated witth tfplugindocs)
  • update provider and data source with terraform-plugin-framework
  • add env variable on provider config
  • update flatmap and list values using terraform
  • add cty support for decoding
  • overall refactor

@EtienneM EtienneM requested a review from johnsudaar May 31, 2022 16:10
@Soulou
Copy link
Member

Soulou commented Jun 13, 2022

@benydc That's an awesome work you've done here. We've to take time to check your changes to ensure they are correctly retro-compatible

@benydc
Copy link
Author

benydc commented Jun 17, 2022

@benydc That's an awesome work you've done here. We've to take time to check your changes to ensure they are correctly retro-compatible

@Soulou thank you! 👍 that's fine, if there are requested changes or new features to add I'm happy to contribute!

@johnsudaar
Copy link

Hello @benydc, and thanks again for your contribution!

Unfortunately as you may have noticed, we failed to review it in a reasonable time, leading it to drift a lot from the master branch.
We are sorry for that.Still, we would like to have the opportunity to review, and then properly merge your changes.
Do you think you could submit those again?
If so, to simplify the review, and thus prevent submitting work that would not be merge one more time, would it be possible for you to split it across several, smaller PRs, and give more details on what you are proposing?

On a first look, we could imagine:

  • One dedicated to the generated documentation
  • One dedicated to the update of provider and data source
  • One dedicated to the overall refactoring
  • And so on...What do you think?

Once again, we are sorry to have missed to review your proposition.

We hope to see your contributions again!

@EtienneM EtienneM removed the request for review from johnsudaar February 3, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants