Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(logger): add support for log tags #1027

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

feat(logger): add support for log tags #1027

wants to merge 9 commits into from
+288 −0

Conversation

john-scalingo
Copy link

@john-scalingo john-scalingo commented Dec 30, 2024 •
edited by EtienneM
Loading

  • Add a changelog entry in CHANGELOG.md

@john-scalingo john-scalingo self-assigned this Dec 30, 2024
@john-scalingo john-scalingo force-pushed the experiment/loggable branch 2 times, most recently from 5a13515 to fea09fc Compare December 30, 2024 14:57
@EtienneM
Copy link
Member

For the record, I asked for feedbacks here: https://scalingo.slack.com/archives/C67P0UZ1C/p1735571253973889

@john-scalingo john-scalingo changed the title expermient(logs) Add support log tags experiment(logs) Add support log tags Dec 30, 2024
@EtienneM EtienneM changed the title experiment(logs) Add support log tags feat(logger): add support for log tags Dec 31, 2024
sc-david-voisin
sc-david-voisin reviewed Jan 7, 2025
View reviewed changes
logger/loggable.go Outdated Show resolved Hide resolved
logger/loggable.go Show resolved Hide resolved
@EtienneM EtienneM force-pushed the experiment/loggable branch from fea09fc to d3b0a4d Compare January 7, 2025 09:33
@EtienneM EtienneM self-assigned this Jan 7, 2025
@EtienneM EtienneM marked this pull request as ready for review January 7, 2025 10:13
sc-david-voisin
sc-david-voisin approved these changes Jan 7, 2025
View reviewed changes
Copy link

@sc-david-voisin sc-david-voisin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

logger/loggable.go Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EtienneM EtienneM EtienneM left review comments

@sc-david-voisin sc-david-voisin sc-david-voisin approved these changes

Assignees

@EtienneM EtienneM

@john-scalingo john-scalingo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@john-scalingo @EtienneM @sc-david-voisin