Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FireFox not streaming VPX on SPS #59

Merged
merged 7 commits into from
Jul 24, 2024
Merged

Fix FireFox not streaming VPX on SPS #59

merged 7 commits into from
Jul 24, 2024

Conversation

lukehb
Copy link
Collaborator

@lukehb lukehb commented Jul 24, 2024

Firefox was unable to stream VPX streams after upgrading to Firefox 128.0.

The details are contained in this PR from the PSInfra: EpicGamesExt/PixelStreamingInfrastructure#204

Relevant components:

  • Scalable Pixel Streaming Frontend library
  • Examples
  • Docs

Problem statement:

Two problems:

  1. Firefox was unable to stream when using VPX codecs.
  2. Two config messages were being sent.

Solution

Two solutions:

  1. Update SPS library to use lib-pixelstreamingfrontend-ue5.5 version 0.1.4, which contains the fix for Firefox being unable to stream VPX.
  2. Unregister all config message listeners and add our custom config message listener that we use for handling the BrowserSendOffer configuration we get from our custom signalling server.

Documentation

I have updated the SPS docs in this repo to refer to pixelstreamingfrontend-ue5.5 as opposed to ue5.4 version/

Test Plan and Compatibility

Tested on:

Chrome + H.264 + CW = It streams
Chrome + VP8 + CW = It streams
FF + H.264 + CW = It streams
FF + VP8 + CW = It streams

@lukehb lukehb requested a review from dan-tw July 24, 2024 06:51
@dan-tw dan-tw merged commit bca9e1f into main Jul 24, 2024
1 check passed
@dan-tw dan-tw deleted the ff-fix branch July 24, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants