Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release v1.6.0 error loading shared library #140

Closed
Ajris opened this issue Mar 9, 2023 · 12 comments · Fixed by #141
Closed

New release v1.6.0 error loading shared library #140

Ajris opened this issue Mar 9, 2023 · 12 comments · Fixed by #141
Assignees
Labels
bug Something isn't working

Comments

@Ajris
Copy link

Ajris commented Mar 9, 2023

Hi, after new release, we have observed an issue:

Run scacap/action-surefire-report@v1
with:
check_name: All Tests Result
github_token: ***
report_paths: **/surefire-reports/TEST-.xml, **/failsafe-reports/TEST-.xml
create_check: true
fail_on_test_failures: false
fail_if_no_tests: true
skip_publishing: false
file_name_in_stack_trace: false

node:internal/modules/cjs/loader:1189
return process.dlopen(module, path.toNamespacedPath(filename));
Error: Error loading shared library libstdc++.so.6: No such file or directory (needed by /__w/_actions/scacap/action-surefire-report/v1/dist/build/Release/xmljs.node) at Object.Module._extensions..node (node:internal/modules/cjs/loader:1189:18) at Module.load (node:internal/modules/cjs/loader:981:32) at Function.Module._load (node:internal/modules/cjs/loader:822:12) at Module.require (node:internal/modules/cjs/loader:[10] 05:19) at require (node:internal/modules/cjs/helpers:102:18) at Object.1463 (/__w/_actions/scacap/action-surefire-report/v1/dist/index.js:10137:18) at __nccwpck_require__ (/__w/_actions/scacap/action-surefire-report/v1/dist/index.js:16797:43) at Object.6737 (/__w/_actions/scacap/action-surefire-report/v1/dist/index.js:10091:16) at __nccwpck_require__ (/__w/_actions/scacap/action-surefire-report/v1/dist/index.js:16797:43) at Object.[12] { code: 'ERR_DLOPEN_FAILED' }

@Ajris Ajris changed the title V1.6.0 error New release v1.6.0 error loading shared library Mar 9, 2023
@ghaiszaher
Copy link
Member

@nineinchnick would you know anything about this? I tried the new version internally and didn't face such issues.

@Ajris
Copy link
Author

Ajris commented Mar 9, 2023

For anyone facing the similar issue, changing the version directly to the v1.5.0 solves the problem temporarily :)

@ghaiszaher
Copy link
Member

@Ajris I reverted the tag v1 to the previous version v1.5.0.

@ghaiszaher
Copy link
Member

@Ajris could you provide the configuration of the GitHub workflow using this action?

@ghaiszaher ghaiszaher self-assigned this Mar 9, 2023
@ghaiszaher ghaiszaher added the bug Something isn't working label Mar 9, 2023
@nineinchnick
Copy link
Contributor

Are you using GitHub's or self-hosted runners? Which OS? This was tested only on ubuntu-latest.

1.6 switches to using a native library for parsing XML, so it requires some shared libraries in the OS. To mitigate this, we should probably run the action in a container.

@Ajris
Copy link
Author

Ajris commented Mar 9, 2023

We are using github's hosted runners and maven containers.

Example job config:

jobs:
  test:
    runs-on: ubuntu-latest
    container:
      image: maven:3.8.6-eclipse-temurin-17-alpine

The configuration of the step:

      - name: Publish Test Report
        uses: scacap/action-surefire-report@v1
        with:
          check_name: ${{ inputs.report-name }}

Sorry for formatting, seems like GH is not respecting the \n.

@ghaiszaher
Copy link
Member

To mitigate this, we should probably run the action in a container.

I'd like to go with this option, which was also on my list (will also solve #130). I can spend some time on it in the next few days.

For the time being I'll keep v1 pointing to v1.5.0 to not break more workflows, you can still specify v1.6.0 if it's compatible with your runners.

@ghaiszaher
Copy link
Member

@Ajris could you verify that v1 is working again for you now?

@Ajris
Copy link
Author

Ajris commented Mar 9, 2023

V1 is working again.
I have runned it and it had downloaded the version with this sha: a2d14ba and everything was as before.

For us, we have just directly changed it to the v1.5.0 in case of any errors.

@nineinchnick
Copy link
Contributor

We are using a container already, aren't we? https://github.com/ScaCap/action-surefire-report/blob/master/action.yml#L52

Specifying container on the job level overrides that. I'm trying to find relevant Github docs for that.

@nineinchnick
Copy link
Contributor

Ah, it's not a container, just a runtime.

@ghaiszaher
Copy link
Member

@nineinchnick thanks for the fix.

@Ajris the action should run properly now for tag v1 or v1.6.1. Feel free to reopen if you still face issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants