Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Bump cryptography from 43.0.3 to 44.0.0 PR#17004" #17011

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

Odilhao
Copy link
Contributor

@Odilhao Odilhao commented Nov 28, 2024

This reverts commit cfce89a.

Problem Statement

Updating cryptography to 44.0.0 causes the following error:

11:03:30  _ ERROR at setup of TestGCEHostProvisioningTestCase.test_positive_gce_host_provisioned[sat] _
11:03:30  pytest_fixtures/component/provision_gce.py:92: in gce_latest_rhel_uuid
11:03:30      templates = googleclient.find_templates(
11:03:30  ../../lib64/python3.12/site-packages/wrapanapi/systems/google.py:721: in find_templates
11:03:30      return self._list_templates(
11:03:30  ../../lib64/python3.12/site-packages/wrapanapi/systems/google.py:664: in _list_templates
11:03:30      .execute()
11:03:30  ../../lib64/python3.12/site-packages/googleapiclient/_helpers.py:130: in positional_wrapper
11:03:30      return wrapped(*args, **kwargs)
11:03:30  ../../lib64/python3.12/site-packages/googleapiclient/http.py:923: in execute
11:03:30      resp, content = _retry_request(
11:03:30  ../../lib64/python3.12/site-packages/googleapiclient/http.py:191: in _retry_request
11:03:30      resp, content = http.request(uri, method, *args, **kwargs)
11:03:30  ../../lib64/python3.12/site-packages/oauth2client/transport.py:159: in new_request
11:03:30      credentials._refresh(orig_request_method)
11:03:30  ../../lib64/python3.12/site-packages/oauth2client/client.py:749: in _refresh
11:03:30      self._do_refresh_request(http)
11:03:30  ../../lib64/python3.12/site-packages/oauth2client/client.py:774: in _do_refresh_request
11:03:30      body = self._generate_refresh_request_body()
11:03:30  ../../lib64/python3.12/site-packages/oauth2client/client.py:1484: in _generate_refresh_request_body
11:03:30      assertion = self._generate_assertion()
11:03:30  ../../lib64/python3.12/site-packages/oauth2client/service_account.py:384: in _generate_assertion
11:03:30      return crypt.make_signed_jwt(self._signer, payload,
11:03:30  ../../lib64/python3.12/site-packages/oauth2client/crypt.py:97: in make_signed_jwt
11:03:30      signature = signer.sign(signing_input)
11:03:30  ../../lib64/python3.12/site-packages/oauth2client/_openssl_crypt.py:97: in sign
11:03:30      return crypto.sign(self._key, message, 'sha256')
11:03:30  ../../lib64/python3.12/site-packages/cryptography/utils.py:68: in __getattr__
11:03:30      obj = getattr(self._module, attr)
11:03:30  E   AttributeError: module 'OpenSSL.crypto' has no attribute 'sign'

Solution

Reverting to 43.0.3 makes sanity jobs work again.

Related Issues

@Odilhao Odilhao requested a review from a team as a code owner November 28, 2024 15:42
@Odilhao Odilhao added CherryPick PR needs CherryPick to previous branches 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z Introduced in or relating directly to Satellite 6.16 labels Nov 28, 2024
this will avoid API/Version breaks for dependabot updates.
To move to a new Y release it will need manual bump.
@jameerpathan111 jameerpathan111 merged commit 7817d59 into SatelliteQE:master Nov 28, 2024
8 checks passed
@jameerpathan111 jameerpathan111 changed the title Revert "Bump cryptography from 43.0.3 to 44.0.0 (#17004)" Revert "Bump cryptography from 43.0.3 to 44.0.0 PR#17004" Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z Introduced in or relating directly to Satellite 6.16 CherryPick PR needs CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants