Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Purpose addons related test code #17009

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Remove Purpose addons related test code #17009

merged 1 commit into from
Nov 29, 2024

Conversation

jameerpathan111
Copy link
Contributor

Problem Statement

purpose_addons is removed from katello Katello/katello#11196 causing robottelo tests to fail and blocking stream snap templatization pipeline.

Solution

  • Remove test code related to purpose_addons
  • I'm not very confident about change in tests/foreman/data/hammer_commands.json but I guess we can worry about it later.

Related Issues

@jameerpathan111 jameerpathan111 added No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master labels Nov 28, 2024
@jameerpathan111 jameerpathan111 self-assigned this Nov 28, 2024
@jameerpathan111 jameerpathan111 requested review from a team as code owners November 28, 2024 07:52
@jameerpathan111 jameerpathan111 mentioned this pull request Nov 28, 2024
Merged
lhellebr
lhellebr approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@lhellebr lhellebr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Just a question, why does it block templatization?

@Odilhao
Copy link
Contributor

Odilhao commented Nov 28, 2024

LGTM. Just a question, why does it block templatization?

This blocks sanity test, with sanity failing we never get to templatization.

@pondrejk pondrejk merged commit 6e0efb8 into SatelliteQE:master Nov 29, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pondrejk pondrejk pondrejk approved these changes

@Odilhao Odilhao Odilhao approved these changes

@lhellebr lhellebr lhellebr approved these changes

Assignees

@jameerpathan111 jameerpathan111

Labels
No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jameerpathan111 @Odilhao @lhellebr @pondrejk