Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

host: tests for new search options #15539

Merged
merged 1 commit into from
Nov 20, 2024
Merged

host: tests for new search options #15539

merged 1 commit into from
Nov 20, 2024

Conversation

pnovotny
Copy link
Contributor

@pnovotny pnovotny commented Jul 1, 2024 •
edited
Loading

Problem Statement

RFE SAT-9132 adds new search options for hosts.

Solution

Two new tests were added for searching hosts with these new options:

  • reported data, like, BIOS vendor, version, etc.
  • new alias configuration_status for status

Related Issues

Requires
SatelliteQE/airgun#1453
SatelliteQE/airgun#1603
SatelliteQE/nailgun#1202

@pnovotny pnovotny added CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.15.z Introduced in or relating directly to Satellite 6.15 labels Jul 1, 2024
@pnovotny pnovotny self-assigned this Jul 1, 2024
@pnovotny pnovotny requested review from pondrejk, lhellebr and a team July 1, 2024 05:17
@pnovotny
Copy link
Contributor Author

pnovotny commented Jul 1, 2024

trigger: test-robottelo
pytest: tests/foreman/ui/test_host.py -k 'test_positive_search_by_configuration_status_alias or test_positive_search_by_reported_data'
airgun: 1453
nailgun: 1202

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7578
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_host.py -k test_positive_search_by_configuration_status_alias or test_positive_search_by_reported_data --external-logging
Test Result : ===== 1 failed, 1 passed, 45 deselected, 89 warnings in 766.44s (0:12:46) ======

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Jul 1, 2024
@pnovotny pnovotny force-pushed the host-search-advanced-params branch from cb4dc22 to e089161 Compare July 1, 2024 11:32
@pnovotny pnovotny removed the PRT-Failed Indicates that latest PRT run is failed for the PR label Jul 1, 2024
@pnovotny
Copy link
Contributor Author

pnovotny commented Jul 1, 2024

trigger: test-robottelo
pytest: tests/foreman/ui/test_host.py -k 'test_positive_search_by_configuration_status_alias or test_positive_search_by_reported_data'
airgun: 1453
nailgun: 1202

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7589
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_host.py -k test_positive_search_by_configuration_status_alias or test_positive_search_by_reported_data --external-logging
Test Result : ===== 1 failed, 1 passed, 45 deselected, 94 warnings in 1043.89s (0:17:23) =====

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Jul 1, 2024
@pnovotny pnovotny force-pushed the host-search-advanced-params branch from e089161 to 106f013 Compare July 1, 2024 15:53
@pnovotny
Copy link
Contributor Author

pnovotny commented Jul 1, 2024

trigger: test-robottelo
pytest: tests/foreman/ui/test_host.py -k 'test_positive_search_by_configuration_status_alias or test_positive_search_by_reported_data'
airgun: 1453
nailgun: 1202

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7594
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_host.py -k test_positive_search_by_configuration_status_alias or test_positive_search_by_reported_data --external-logging
Test Result : ===== 1 failed, 1 passed, 45 deselected, 96 warnings in 1083.38s (0:18:03) =====

@pnovotny pnovotny force-pushed the host-search-advanced-params branch from 106f013 to e427c6e Compare July 2, 2024 12:48
@pnovotny pnovotny removed the PRT-Failed Indicates that latest PRT run is failed for the PR label Jul 2, 2024
@pnovotny
Copy link
Contributor Author

pnovotny commented Jul 2, 2024

trigger: test-robottelo
pytest: tests/foreman/ui/test_host.py -k 'test_positive_search_by_configuration_status_alias or test_positive_search_by_reported_data'
airgun: 1453
nailgun: 1202

@pnovotny pnovotny marked this pull request as ready for review July 2, 2024 12:48
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7602
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_host.py -k test_positive_search_by_configuration_status_alias or test_positive_search_by_reported_data --external-logging
Test Result : ========== 2 passed, 45 deselected, 97 warnings in 1100.09s (0:18:20) ==========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Jul 2, 2024
vijaysawant
vijaysawant reviewed Jul 2, 2024
View reviewed changes
Copy link
Contributor

@vijaysawant vijaysawant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try without no_containers marker, it should work, rest of things looks good.

tests/foreman/ui/test_host.py Show resolved Hide resolved
pondrejk
pondrejk approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@pondrejk pondrejk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack pending existing comments

@pnovotny pnovotny force-pushed the host-search-advanced-params branch from e427c6e to 482b961 Compare July 3, 2024 09:33
@pnovotny
Copy link
Contributor Author

pnovotny commented Jul 3, 2024

trigger: test-robottelo
pytest: tests/foreman/ui/test_host.py -k 'test_positive_search_by_configuration_status_alias or test_positive_search_by_reported_data'
airgun: 1453
nailgun: 1202

@pnovotny pnovotny removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Jul 3, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7618
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_host.py -k test_positive_search_by_configuration_status_alias or test_positive_search_by_reported_data --external-logging
Test Result : ========== 2 passed, 45 deselected, 96 warnings in 862.09s (0:14:22) ===========

Gauravtalreja1
Gauravtalreja1 reviewed Jul 15, 2024
View reviewed changes
tests/foreman/ui/test_host.py Outdated Show resolved Hide resolved
tests/foreman/ui/test_host.py Show resolved Hide resolved
@jyejare jyejare added the 6.16.z Introduced in or relating directly to Satellite 6.16 label Aug 22, 2024
@pnovotny pnovotny removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Sep 5, 2024
@pnovotny pnovotny mentioned this pull request Sep 5, 2024
Merged
@Gauravtalreja1
Copy link
Collaborator

@pnovotny Could you update this PR?

@pnovotny pnovotny force-pushed the host-search-advanced-params branch from 9148b95 to 38d255d Compare October 21, 2024 11:56
@pnovotny
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_host.py -k 'test_positive_search_by_configuration_status_alias or test_positive_search_by_reported_data'
airgun: 1603

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9050
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_host.py -k test_positive_search_by_configuration_status_alias or test_positive_search_by_reported_data --external-logging
Test Result : ========= 2 passed, 78 deselected, 173 warnings in 2013.43s (0:33:33) ==========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Oct 21, 2024
@pnovotny pnovotny mentioned this pull request Oct 21, 2024
Merged
@pnovotny pnovotny force-pushed the host-search-advanced-params branch from 38d255d to aed73cd Compare October 23, 2024 14:34
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Oct 23, 2024
@pnovotny
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_host.py -k 'test_positive_search_by_configuration_status_alias or test_positive_search_by_reported_data'
airgun: 1603

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9118
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_host.py -k test_positive_search_by_configuration_status_alias or test_positive_search_by_reported_data --external-logging
Test Result : ========== 2 passed, 78 deselected, 126 warnings in 928.25s (0:15:28) ==========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Oct 23, 2024
LadislavVasina1
LadislavVasina1 approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@LadislavVasina1 LadislavVasina1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@pnovotny
hosts: new tests for searching with more options
dea8df1 
Two new tests were added for searching hosts with new options:
- reported data, like, BIOS vendor, version, etc.
- new alias `configuration_status` for `status`
@pnovotny pnovotny force-pushed the host-search-advanced-params branch from aed73cd to dea8df1 Compare November 19, 2024 18:20
@pnovotny
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_host.py -k 'test_positive_search_by_configuration_status_alias or test_positive_search_by_reported_data'
airgun: 1603

@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Nov 19, 2024
@pnovotny
Copy link
Contributor Author

Rebased. Rerunning PRT just to be sure.

@pnovotny
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_host.py -k 'test_positive_search_by_configuration_status_alias or test_positive_search_by_reported_data'
airgun: 1603

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9407
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_host.py -k test_positive_search_by_configuration_status_alias or test_positive_search_by_reported_data --external-logging
Test Result : ========== 2 passed, 78 deselected, 126 warnings in 921.58s (0:15:21) ==========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Nov 20, 2024
@pondrejk pondrejk merged commit f9eacdc into SatelliteQE:master Nov 20, 2024
11 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 20, 2024
@pnovotny @web-flow
host: tests for new search options (#15539)
2585c22 
hosts: new tests for searching with more options

Two new tests were added for searching hosts with new options:
- reported data, like, BIOS vendor, version, etc.
- new alias `configuration_status` for `status`

(cherry picked from commit f9eacdc)
@Satellite-QE Satellite-QE mentioned this pull request Nov 20, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Nov 20, 2024
@pnovotny @web-flow
host: tests for new search options (#15539)
66cfbc4 
hosts: new tests for searching with more options

Two new tests were added for searching hosts with new options:
- reported data, like, BIOS vendor, version, etc.
- new alias `configuration_status` for `status`

(cherry picked from commit f9eacdc)
@Satellite-QE Satellite-QE mentioned this pull request Nov 20, 2024
Merged
@pnovotny pnovotny deleted the host-search-advanced-params branch November 22, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 left review comments

@ogajduse ogajduse ogajduse left review comments

@LadislavVasina1 LadislavVasina1 LadislavVasina1 approved these changes

@vijaysawant vijaysawant vijaysawant approved these changes

@pondrejk pondrejk pondrejk approved these changes

@lhellebr lhellebr lhellebr approved these changes

Assignees

@pnovotny pnovotny

Labels
6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z Introduced in or relating directly to Satellite 6.16 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@pnovotny @Satellite-QE @Gauravtalreja1 @lhellebr @pondrejk @ogajduse @vijaysawant @LadislavVasina1 @jyejare