Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated in hammer ping stderr parsing #15394

Merged
merged 1 commit into from
Jun 11, 2024
Merged

updated in hammer ping stderr parsing #15394

merged 1 commit into from
Jun 11, 2024

Conversation

pondrejk
Copy link
Contributor

Problem Statement

automation failures with IndexError: string index out of range

Solution

this pr

Related Issues

note to self: prt won't run atm, rerun later with:

trigger: test-robottelo
pytest: tests/foreman/cli/test_ping.py -k test_positive_ping[non-root]

@pondrejk pondrejk added TestFailure Issues and PRs related to a test failing in automation No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master labels Jun 11, 2024
@pondrejk pondrejk self-assigned this Jun 11, 2024
@pondrejk pondrejk requested a review from a team as a code owner June 11, 2024 11:16
lpramuk
lpramuk approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@lpramuk lpramuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK pending PRT

@pondrejk
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_ping.py -k test_positive_ping[non-root]

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7355
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_ping.py -k test_positive_ping[non-root] --external-logging
Test Result : =========== 1 passed, 1 deselected, 10 warnings in 570.55s (0:09:30) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Jun 11, 2024
@pondrejk pondrejk merged commit 79a7832 into SatelliteQE:master Jun 11, 2024
12 checks passed
@dosas dosas mentioned this pull request Jun 18, 2024
Merged
@dosas
Copy link
Collaborator

dosas commented Jun 18, 2024

@pondrejk Shouldn't this change be cherry-picked to all the branches where broker 0.5 is used?
#15221

This was referenced Jun 25, 2024
Merged
Merged
Merged
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
@pondrejk @jyejare
updated in hammer ping stderr parsing (SatelliteQE#15394)
483edc4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpramuk lpramuk lpramuk approved these changes

@lhellebr lhellebr lhellebr approved these changes

Assignees

@pondrejk pondrejk

Labels
No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR Stream Introduced in or relating directly to Satellite Stream/Master TestFailure Issues and PRs related to a test failing in automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pondrejk @Satellite-QE @dosas @lhellebr @lpramuk