Skip orphan cleanup case for n_minus scenario #14371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsedmik
added
Easy Fix :)
|
@vsedmik @damoore044 Lets wait for cherrypicks of NMinus to merge else the cherrypicks here will fail. Or since its blocking the test in master from running we can merge this and manually cherrypick them later. I really wish we will bring back the Autocherrypick of Merged PRs! |
|
Let me update the codebase to include that again ? @jyejare |
|
@omkarkhatavkar lets discuss that in tomorrows call. |
Gauravtalreja1
approved these changes
Mar 12, 2024
damoore044
approved these changes
Mar 12, 2024
synkd
approved these changes
Mar 12, 2024
lhellebr
approved these changes
Mar 14, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Mar 14, 2024
(cherry picked from commit 672ba8d)
This was referenced Mar 14, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Mar 14, 2024
(cherry picked from commit 672ba8d)
github-actions bot
pushed a commit
that referenced
this pull request
Mar 14, 2024
(cherry picked from commit 672ba8d)
vsedmik
added a commit
that referenced
this pull request
Mar 14, 2024
Skip orphan cleanup case for n_minus scenario (#14371) (cherry picked from commit 672ba8d) Co-authored-by: vsedmik <[email protected]>
vsedmik
added a commit
that referenced
this pull request
Mar 14, 2024
Skip orphan cleanup case for n_minus scenario (#14371) (cherry picked from commit 672ba8d) Co-authored-by: vsedmik <[email protected]>
vsedmik
added a commit
that referenced
this pull request
Mar 14, 2024
Skip orphan cleanup case for n_minus scenario (#14371) (cherry picked from commit 672ba8d) Co-authored-by: vsedmik <[email protected]>
damoore044
pushed a commit
to damoore044/robottelo
that referenced
this pull request
Mar 18, 2024
…4409) Skip orphan cleanup case for n_minus scenario (SatelliteQE#14371) (cherry picked from commit 672ba8d) Co-authored-by: vsedmik <[email protected]>
shweta83
pushed a commit
to shweta83/robottelo
that referenced
this pull request
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
Orphan cleanup test case should be skipped for n_minus scenario but run in normal runs.
Solution
Flip the logic.