Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close-loop BZ2217079 #14276

Merged
merged 3 commits into from
Apr 24, 2024
Merged

Close-loop BZ2217079 #14276

merged 3 commits into from
Apr 24, 2024

Conversation

lhellebr
Copy link
Contributor

@lhellebr lhellebr commented Mar 7, 2024

No description provided.

@lhellebr lhellebr added CherryPick PR needs CherryPick to previous branches 6.15.z Introduced in or relating directly to Satellite 6.15 labels Mar 7, 2024
@lhellebr lhellebr requested a review from a team as a code owner March 7, 2024 09:10
@lhellebr
Copy link
Contributor Author

lhellebr commented Mar 7, 2024

trigger: test-robottelo
pytest: tests/foreman/cli/test_remoteexecution.py::TestPullProviderRex::test_positive_run_job_in_chosen_directory

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 5971
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_remoteexecution.py::TestPullProviderRex::test_positive_run_job_in_chosen_directory --external-logging
Test Result : ================= 6 passed, 528 warnings in 4274.13s (1:11:14) =================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Mar 7, 2024
@lhellebr
Copy link
Contributor Author

lhellebr commented Mar 7, 2024

trigger: test-robottelo
pytest: tests/foreman/cli/test_remoteexecution.py::TestPullProviderRex::test_positive_run_job_in_chosen_directory

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 5982
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_remoteexecution.py::TestPullProviderRex::test_positive_run_job_in_chosen_directory --external-logging
Test Result : ================= 6 passed, 521 warnings in 4230.18s (1:10:30) =================

@lhellebr lhellebr requested a review from a team March 7, 2024 16:11
@shweta83
Copy link
Contributor

@lhellebr Can you please add some description on the PR?

pondrejk
pondrejk approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@pondrejk pondrejk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack, just add bz to docstring

tests/foreman/cli/test_remoteexecution.py Show resolved Hide resolved
shubhamsg199
shubhamsg199 approved these changes Mar 13, 2024
View reviewed changes
tests/foreman/cli/test_remoteexecution.py Outdated

:expectedresults: Verify the job was successfully ran against the host registered to mqtt, in the correct directory

:CaseImportance: High
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already defined at the module level

Suggested change
:CaseImportance: High

@lhellebr
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_remoteexecution.py::TestPullProviderRex::test_positive_run_job_in_chosen_directory

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6125
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_remoteexecution.py::TestPullProviderRex::test_positive_run_job_in_chosen_directory --external-logging
Test Result : ================= 6 passed, 557 warnings in 4459.27s (1:14:19) =================

@lhellebr lhellebr requested a review from a team March 21, 2024 16:24
@lhellebr
Copy link
Contributor Author

Merge?

@pondrejk pondrejk added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Apr 22, 2024
@pondrejk
Copy link
Contributor

@lhellebr please rebase, seems there's some conflict to be resolved

@lhellebr
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_remoteexecution.py::TestPullProviderRex::test_positive_run_job_in_chosen_directory

@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 23, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6657
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_remoteexecution.py::TestPullProviderRex::test_positive_run_job_in_chosen_directory --external-logging
Test Result : ================= 6 passed, 604 warnings in 4609.76s (1:16:49) =================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 23, 2024
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 24, 2024
@lhellebr
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_remoteexecution.py::TestPullProviderRex::test_positive_run_job_in_chosen_directory

@lhellebr
Copy link
Contributor Author

CQ failures unrelated, dependency installation failure

@lhellebr
Copy link
Contributor Author

After PRT passes again, let's please merge it. I don't enjoy rebasing a PR after it's been pending for two months.

@lhellebr
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_remoteexecution.py::TestPullProviderRex::test_positive_run_job_in_chosen_directory

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6676
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_remoteexecution.py::TestPullProviderRex::test_positive_run_job_in_chosen_directory --external-logging
Test Result : ================= 6 passed, 545 warnings in 4237.17s (1:10:37) =================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 24, 2024
@jameerpathan111 jameerpathan111 merged commit a5c839a into SatelliteQE:master Apr 24, 2024
10 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 24, 2024
@lhellebr @web-flow
Close-loop BZ2217079 (#14276)
a419e79 
* Close-loop BZ2217079

* pre-commit fix

* Revert ID change

(cherry picked from commit a5c839a)
@Satellite-QE Satellite-QE mentioned this pull request Apr 24, 2024
Merged
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
@lhellebr @jyejare
Close-loop BZ2217079 (SatelliteQE#14276)
5a80ecd 
* Close-loop BZ2217079

* pre-commit fix

* Revert ID change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubhamsg199 shubhamsg199 shubhamsg199 approved these changes

@jameerpathan111 jameerpathan111 jameerpathan111 approved these changes

@pondrejk pondrejk pondrejk approved these changes

@pnovotny pnovotny pnovotny approved these changes

Assignees

@lhellebr lhellebr

Labels
6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lhellebr @Satellite-QE @shweta83 @pondrejk @pnovotny @jameerpathan111 @shubhamsg199