Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the PRT labels for new commits #14093

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

omkarkhatavkar
Copy link

@omkarkhatavkar omkarkhatavkar commented Feb 15, 2024

Problem Statement

Currently, the labels PRT-Passed and PRT-Failed are added based on the results of the Pull Request Testing (PRT). However, when contributors update the pull request with new commits, these labels might remain, leading to potential confusion. There is a need to automatically remove these labels when new commits are added to the pull request.

Solution

To address this issue, we propose implementing a solution using GitHub Actions (GHA). The solution involves periodically checking the GitHub status API to monitor for new commits on the pull request. Upon detecting a new commit, the workflow will automatically remove the PRT-Passed and PRT-Failed labels from the pull request. This ensures that the labels accurately reflect the current status of the pull request, reducing confusion and maintaining clarity for reviewers and contributors.

Test Result

https://github.com/omkarkhatavkar/robottelo/actions/runs/7916581527/job/21610780591?pr=216

@omkarkhatavkar omkarkhatavkar requested a review from a team as a code owner February 15, 2024 13:29
@omkarkhatavkar omkarkhatavkar added CherryPick PR needs CherryPick to previous branches 6.12.z Introduced in or relating directly to Satellite 6.12 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Feb 15, 2024
@omkarkhatavkar omkarkhatavkar force-pushed the prt_labels branch 2 times, most recently from 40f89a5 to c9db2e1 Compare February 15, 2024 14:11
@omkarkhatavkar
Copy link
Author

Dont worry about the failing check here as It will be going to get added. It will work only after getting merge because the github token for SatQE is inside the repo.

Copy link
Member

@jyejare jyejare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK pending comments and suggestions!

.github/workflows/prt_labels.yml Outdated Show resolved Hide resolved
.github/workflows/prt_labels.yml Outdated Show resolved Hide resolved
.github/workflows/prt_labels.yml Outdated Show resolved Hide resolved
.github/workflows/prt_labels.yml Show resolved Hide resolved
@omkarkhatavkar omkarkhatavkar force-pushed the prt_labels branch 2 times, most recently from 0c20d18 to 5353ee1 Compare February 22, 2024 10:51
Copy link
Member

@jyejare jyejare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK pending another suggestion. Sorry for double review :)

.github/workflows/prt_labels.yml Show resolved Hide resolved
@omkarkhatavkar omkarkhatavkar force-pushed the prt_labels branch 3 times, most recently from 2d55366 to 19cdb60 Compare February 27, 2024 10:04
@jyejare jyejare merged commit a98258c into SatelliteQE:master Mar 8, 2024
7 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 8, 2024
github-actions bot pushed a commit that referenced this pull request Mar 8, 2024
github-actions bot pushed a commit that referenced this pull request Mar 8, 2024
github-actions bot pushed a commit that referenced this pull request Mar 8, 2024
jyejare pushed a commit that referenced this pull request Mar 8, 2024
remove the PRT labels for new commits (#14093)

(cherry picked from commit a98258c)

Co-authored-by: Omkar Khatavkar <[email protected]>
Gauravtalreja1 pushed a commit that referenced this pull request Mar 11, 2024
remove the PRT labels for new commits (#14093)

(cherry picked from commit a98258c)

Co-authored-by: Omkar Khatavkar <[email protected]>
Gauravtalreja1 pushed a commit that referenced this pull request Mar 11, 2024
remove the PRT labels for new commits (#14093)

(cherry picked from commit a98258c)

Co-authored-by: Omkar Khatavkar <[email protected]>
Gauravtalreja1 pushed a commit that referenced this pull request Mar 11, 2024
remove the PRT labels for new commits (#14093)

(cherry picked from commit a98258c)

Co-authored-by: Omkar Khatavkar <[email protected]>
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.12.z Introduced in or relating directly to Satellite 6.12 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 CherryPick PR needs CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants