-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Customer Case]Adding test for invalid release version #13296
[Customer Case]Adding test for invalid release version #13296
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- fixture which is being use for organization needs to check separately on 6.14 and 6.15
- few non-blocking request for changes
- use of API and CLI functions suggestion
Otherwise rest of things are good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack
Please run PRT comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack looks good! pending prt
trigger: test-robottelo |
reposet=REPOS['kickstart']['rhel8_aps']['reposet'], | ||
releasever=REPOS['kickstart']['rhel8_aps']['version'], | ||
) | ||
Repository.synchronize({'id': rh_repo_id}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't you remove the import for this and just do
Repository.synchronize({'id': rh_repo_id}) | |
module_target_sat.cli.Repository.synchronize({'id': rh_repo_id}) |
e8e24bb
to
00b9407
Compare
trigger: test-robottelo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, left two comments for @ColeHiggins2 to consider.
PRT failure is unrelated to this PR.
|
||
:expectedresults: Invalid release versions should fail and valid release version should succeed | ||
|
||
:BZ: 1895976 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The BZ has medium
severity, so I would tend to use :CaseImportance: Medium
here instead of the module-default High
. Unless there are some other reasons.
{ | ||
'organization-id': module_sca_manifest_org.id, | ||
'name': name, | ||
'release-version': 'ThisShouldNotWork', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be something random via gen_string(...)
or parametrized via invalid_values_list
from datafactory. Non-blocking.
trigger: test-robottelo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Adding test to check invalid release versions when updating or creating an activation key using hammer
:BZ: 1895976