-
Notifications
You must be signed in to change notification settings - Fork 83
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This continues a trend we've done with other projects. Codecov has some use in other types of projects, but really isn't a good fit for Nailgun since it is functionally exercised by Robottelo. Without getting too deep into philosophy, CodeCov is a misleading metric for quality and minor changes are largely ignored in mature projects. (cherry picked from commit ef2c9e7) Co-authored-by: Jacob Callahan <[email protected]>
- Loading branch information
1 parent
cff4b04
commit ffbdc02
Showing
6 changed files
with
3 additions
and
35 deletions.
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -42,10 +42,6 @@ jobs: | |
- name: Pre Commit Checks | ||
uses: pre-commit/[email protected] | ||
|
||
- name: Test Nailgun Coverage | ||
run: | | ||
make test-coverage | ||
- name: Make Docs | ||
run: | | ||
make docs-html | ||
|
@@ -60,11 +56,6 @@ jobs: | |
if: failure() | ||
run: git diff | ||
|
||
- name: Upload Codecov Coverage | ||
uses: codecov/[email protected] | ||
with: | ||
fail_ci_if_error: true | ||
|
||
build-n-publish: | ||
name: Build and publish Python 🐍 distributions 📦 to PyPI | ||
runs-on: ubuntu-latest | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -38,9 +38,8 @@ jobs: | |
pip install --compile --no-cache-dir pycurl | ||
pip install -U -r requirements.txt -r requirements-dev.txt --no-cache-dir | ||
- name: Test Nailgun Coverage | ||
run: | | ||
make test-coverage | ||
- name: Run Tests | ||
run: make test | ||
|
||
- name: Make Docs | ||
run: | | ||
|
@@ -56,7 +55,3 @@ jobs: | |
if: failure() | ||
run: git diff | ||
|
||
- name: Upload Codecov Coverage | ||
uses: codecov/[email protected] | ||
with: | ||
fail_ci_if_error: true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,9 +14,5 @@ wheel | |
# For `make publish` | ||
twine | ||
|
||
# For code coverage | ||
codecov==2.1.13 | ||
coverage[toml] | ||
|
||
# For linting | ||
ruff |