Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add basic embedded app #200

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

✨ Add basic embedded app #200

wants to merge 6 commits into from

Conversation

ponty33
Copy link
Member

@ponty33 ponty33 commented Aug 8, 2023 •
edited
Loading

close #180

  • Add a new arg initial_path. If set to null then there will be nothing on the root, so same 404 as what it is currently
  • If any route is defined, it will then return a plain App Installed
  • This endpoint would also check hmac so it can only be accessed by Shopify

@ponty33 ponty33 self-assigned this Aug 8, 2023
@ponty33 ponty33 changed the title Add basic embedded app ✨ Add basic embedded app Aug 8, 2023
@ponty33
Copy link
Member Author

ponty33 commented Aug 22, 2023

@rahulpatidar0191 Do you know why the test is failing at tox step?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lishanl lishanl Awaiting requested review from lishanl lishanl will be requested when the pull request is marked ready for review lishanl is a code owner

@rahulpatidar0191 rahulpatidar0191 Awaiting requested review from rahulpatidar0191 rahulpatidar0191 will be requested when the pull request is marked ready for review rahulpatidar0191 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@ponty33 ponty33

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add basic embedded app just to have a fully installable app
1 participant
@ponty33