Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/false positive button #819

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Feat/false positive button #819

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66c44d1
feat: add false positive button
jacobkellas Feb 21, 2024
d7a60c9
test: update snapshots
jacobkellas Feb 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions UI/src/components/molecules/RipaOverridePii.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,17 @@

<v-container>
<v-row no-gutters>
<v-col cols="12" sm="12">
Is PII Found: {{ apiStop.isPiiFound }}
<v-col cols="12" sm="12" class="mb-2">
Is PII Found:
{{ apiStop.isPiiFound }}
<v-btn
v-if="apiStop.isPiiFound"
@click="handleFalsePositive"
class="ml-6"
color="primary"
>
False Positive
</v-btn>
</v-col>
<v-col v-if="apiStop.isPiiFound" cols="12" sm="12">
<v-simple-table>
Expand All @@ -27,7 +36,7 @@
</template>
</v-simple-table>
</v-col>
<v-col cols="12" sm="12">
<v-col cols="12" sm="6">
<ripa-switch
v-model="model.overridePii"
label="Override"
Expand Down Expand Up @@ -70,6 +79,12 @@ export default {
handleInput() {
this.$emit('input', this.viewModel)
},

handleFalsePositive() {
this.viewModel.overridePii = true
this.viewModel.editStopExplanation = 'PII Override - false positive'
this.handleInput()
},
},

props: {
Expand Down
8 changes: 5 additions & 3 deletions UI/tests/unit/components/molecules/__snapshots__/RipaFormStep7.spec.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,11 +85,13 @@ exports[`Ripa Form Step 7 should match snapshot 1`] = `
</div>
<div class="container">
<div class="row no-gutters">
<div class="col-sm-12 col-12">
Is PII Found: false
<div class="mb-2 col-sm-12 col-12">
Is PII Found:
false
<!---->
</div>
<!---->
<div class="col-sm-12 col-12">
<div class="col-sm-6 col-12">
<div class="ripa-switch" style="max-width: 250px;">
<div class="v-input v-input--reverse v-input--expand v-input--hide-details theme--light v-input--selection-controls v-input--switch v-input--switch--inset">
<div class="v-input__control">
Expand Down
8 changes: 5 additions & 3 deletions UI/tests/unit/components/molecules/__snapshots__/RipaOverridePii.spec.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,13 @@ exports[`Ripa Override PII should match snapshot 1`] = `
</div>
<div class="container">
<div class="row no-gutters">
<div class="col-sm-12 col-12">
Is PII Found: false
<div class="mb-2 col-sm-12 col-12">
Is PII Found:
false
<!---->
</div>
<!---->
<div class="col-sm-12 col-12">
<div class="col-sm-6 col-12">
<div class="ripa-switch" style="max-width: 250px;">
<div class="v-input v-input--reverse v-input--expand v-input--hide-details theme--light v-input--selection-controls v-input--switch v-input--switch--inset">
<div class="v-input__control">
Expand Down
Loading