Skip to content

Commit

Permalink
Update macOS version in actions
Browse files Browse the repository at this point in the history
Signed-off-by: HyukWoo Park <[email protected]>
  • Loading branch information
clover2123 authored and ksh8281 committed Oct 16, 2024
1 parent f388c52 commit cf0ef12
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 16 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/android-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
overwrite: true

build-android-on-macos:
runs-on: macos-12
runs-on: macos-13
steps:
- uses: actions/checkout@v4
with:
Expand Down
20 changes: 10 additions & 10 deletions .github/workflows/es-actions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,29 +25,29 @@ jobs:
run: tools/check_tidy.py

build-on-macos:
runs-on: macos-12
runs-on: macos-13
steps:
- uses: actions/checkout@v4
with:
submodules: recursive
- name: Install Packages
run: |
brew update
brew install cmake ninja pkg-config
brew install cmake ninja pkg-config icu4c
- name: Build x64
env:
BUILD_OPTIONS: -DESCARGOT_WASM=ON -DESCARGOT_TEMPORAL=ON -DESCARGOT_TCO=ON -DESCARGOT_TEST=ON -DESCARGOT_OUTPUT=shell -GNinja
run: |
cmake -H. -Bout/debug/ -DESCARGOT_MODE=debug $BUILD_OPTIONS
ninja -Cout/debug/
./tools/run-tests.py --engine="./out/debug/escargot" new-es
$RUNNER --engine="./out/debug/escargot" new-es
cmake -H. -Bout/release/ -DESCARGOT_MODE=release $BUILD_OPTIONS
ninja -Cout/release/
cp test/octane/*.js .
./out/release/escargot run.js
build-test-on-android:
runs-on: macos-12
runs-on: macos-13
strategy:
matrix:
arch: [x86, x86_64]
Expand Down Expand Up @@ -99,7 +99,7 @@ jobs:
run: |
CC=clang CXX=clang++ cmake -H. -Bout/clang/x64 $BUILD_OPTIONS
ninja -Cout/clang/x64
./tools/run-tests.py --engine="./out/clang/x64/escargot" new-es
$RUNNER --engine="./out/clang/x64/escargot" new-es
test-on-windows-clang-cl:
runs-on: windows-2022
Expand Down Expand Up @@ -378,9 +378,9 @@ jobs:
cmake --build build/out_linux64_release/
- name: Test
run: |
LD_LIBRARY_PATH=/usr/icu32/lib/ GC_FREE_SPACE_DIVISOR=1 tools/run-tests.py --arch=x86 --engine="${{ github.workspace }}/build/out_linux_release/escargot" test262
LD_LIBRARY_PATH=/usr/icu32/lib/ GC_FREE_SPACE_DIVISOR=1 ESCARGOT_LD_PRELOAD=${{ github.workspace }}/backtrace-hooking-32.so tools/run-tests.py --arch=x86 --engine="${{ github.workspace }}/build/out_linux/escargot" test262
LD_LIBRARY_PATH=/usr/icu64/lib/ GC_FREE_SPACE_DIVISOR=1 tools/run-tests.py --arch=x86_64 --engine="${{ github.workspace }}/build/out_linux64_release/escargot" test262
LD_LIBRARY_PATH=/usr/icu32/lib/ GC_FREE_SPACE_DIVISOR=1 $RUNNER --arch=x86 --engine="${{ github.workspace }}/build/out_linux_release/escargot" test262
LD_LIBRARY_PATH=/usr/icu32/lib/ GC_FREE_SPACE_DIVISOR=1 ESCARGOT_LD_PRELOAD=${{ github.workspace }}/backtrace-hooking-32.so $RUNNER --arch=x86 --engine="${{ github.workspace }}/build/out_linux/escargot" test262
LD_LIBRARY_PATH=/usr/icu64/lib/ GC_FREE_SPACE_DIVISOR=1 $RUNNER --arch=x86_64 --engine="${{ github.workspace }}/build/out_linux64_release/escargot" test262
LD_LIBRARY_PATH=/usr/icu64/lib/ python tools/kangax/run-kangax.py --engine="${{ github.workspace }}/build/out_linux64/escargot"
build-test-on-self-hosted-arm-linux:
Expand All @@ -396,7 +396,7 @@ jobs:
cmake --build ./out/
- name: Test
run: |
GC_FREE_SPACE_DIVISOR=1 tools/run-tests.py --engine="${{ github.workspace }}/out/escargot" --test262-extra-arg="--skip intl402" new-es v8 spidermonkey chakracore test262
GC_FREE_SPACE_DIVISOR=1 $RUNNER --engine="${{ github.workspace }}/out/escargot" --test262-extra-arg="--skip intl402" new-es v8 spidermonkey chakracore test262
build-test-on-self-hosted-arm64-linux:
runs-on: [self-hosted, linux, arm64]
Expand All @@ -411,7 +411,7 @@ jobs:
cmake --build ./out/
- name: Test
run: |
GC_FREE_SPACE_DIVISOR=1 tools/run-tests.py --engine="${{ github.workspace }}/out/escargot" --test262-extra-arg="--skip intl402" test262 chakracore spidermonkey v8 new-es
GC_FREE_SPACE_DIVISOR=1 $RUNNER --engine="${{ github.workspace }}/out/escargot" --test262-extra-arg="--skip intl402" test262 chakracore spidermonkey v8 new-es
build-test-debugger:
runs-on: ubuntu-latest
Expand Down
1 change: 0 additions & 1 deletion build/android/escargot/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@ android {
externalNativeBuild {
cmake {
path "src/main/cpp/CMakeLists.txt"
version "3.18.1"
}
}

Expand Down
2 changes: 0 additions & 2 deletions src/parser/CodeBlock.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -549,15 +549,13 @@ void InterpretedCodeBlock::computeBlockVariables(LexicalBlockIndex currentBlockI
ASSERT(bi != nullptr);

size_t heapIndex = 0;
size_t stackSize = 0;
for (size_t i = 0; i < bi->identifiers().size(); i++) {
if (!m_canAllocateVariablesOnStack) {
bi->identifiers()[i].m_needToAllocateOnStack = false;
}

if (bi->identifiers()[i].m_needToAllocateOnStack) {
bi->identifiers()[i].m_indexForIndexedStorage = currentStackAllocatedVariableIndex;
stackSize++;
currentStackAllocatedVariableIndex++;
maxStackAllocatedVariableDepth = std::max(maxStackAllocatedVariableDepth, currentStackAllocatedVariableIndex);
} else {
Expand Down
2 changes: 0 additions & 2 deletions src/wasm/WASMOperations.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,6 @@ void WASMOperations::readImportsOfModule(ExecutionState& state, wasm_module_t* m
Value v = o.asObject()->get(state, ObjectPropertyName(state, compNameValue)).value(state, o);

bool throwLinkError = false;
size_t externFuncCount = 0;
switch (wasm_externtype_kind(externtype)) {
case WASM_EXTERN_FUNC: {
// If externtype is of the form func functype,
Expand All @@ -425,7 +424,6 @@ void WASMOperations::readImportsOfModule(ExecutionState& state, wasm_module_t* m
funcaddr = wasmCreateHostFunction(state, v.asObject(), wasm_externtype_as_functype(externtype));

// TODO Let index be the number of external functions in imports. This value index is known as the index of the host function funcaddr.
externFuncCount++;
}

// Let externfunc be the external value func funcaddr.
Expand Down

0 comments on commit cf0ef12

Please sign in to comment.