Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(report): Parse data from sarif as URI #845

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Conversation

o-andrieiev
Copy link
Collaborator

Detekt has changed uri format for its sarif report to explicitly define file:/// schema: https://github.com/detekt/detekt/pull/6331/files

It seems Universum can't parse these updated links.
We need to modify core_report_collector to parse uri instead of just unquoting it.

Copy link

Here is the summarized build result:
5. Executing build steps
5.1. [ 1/8 ] Create virtual environment - Success
5.2. [ 2/8 ] Update Docker images - Success
5.3. [ 3/8 ] Install Universum for tests - Success
5.4. [ 4/8 ] Make - Success
5.5. Collecting artifacts for the 'Make' step - Success
5.6. [ 5/8 ] Make tests - Failed
5.7. Collecting artifacts for the 'Make tests' step - Success
5.8. [ 6/8 ] Collect test results - Success
5.9. Collecting artifacts for the 'Collect test results' step - Success
5.10. [ 7/8 ] Run static pylint - Success
5.11. [ 8/8 ] Run static type checker - Success

Here is the link to Github Actions build: https://github.com/Samsung/Universum/actions/runs/10901850141

Copy link

github-actions bot commented Sep 17, 2024

Unit Test Results

713 tests  +1   710 ✔️ +1   20m 48s ⏱️ + 2m 32s
    1 suites ±0       3 💤 ±0 
    1 files   ±0       0 ±0 

Results for commit e50656c. ± Comparison against base commit c065c67.

♻️ This comment has been updated with latest results.

@o-andrieiev o-andrieiev merged commit b0b55a4 into master Oct 28, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants