Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(github): add postcommit workflow #835

Merged
merged 1 commit into from
Nov 24, 2023
Merged

feat(github): add postcommit workflow #835

merged 1 commit into from
Nov 24, 2023

Conversation

k-dovgan
Copy link
Contributor

No description provided.

i-keliukh
i-keliukh approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@i-keliukh i-keliukh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to reuse the same workflow for both pre- and post-commit check?

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 24, 2023 •
edited
Loading

Unit Test Results

711 tests   708 ✔️  18m 28s ⏱️
    1 suites      3 💤
    1 files        0 ❌

Results for commit 9709fc3.

♻️ This comment has been updated with latest results.

@k-dovgan
Copy link
Contributor Author

Is it possible to reuse the same workflow for both pre- and post-commit check?

Not recommended, as pre-commit uses very specific PR payload to extract values and make comments directly to review.
They are triggered by different events and processed differently, so uniting them in one workflow will only complicate things.

miltolstoy
miltolstoy reviewed Nov 24, 2023
View reviewed changes
Copy link
Collaborator

@miltolstoy miltolstoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k-dovgan k-dovgan merged commit da88e6b into master Nov 24, 2023
6 checks passed
@k-dovgan k-dovgan deleted the add-postcommit-workflow branch November 24, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miltolstoy miltolstoy miltolstoy left review comments

@i-keliukh i-keliukh i-keliukh approved these changes

@dogbert911 dogbert911 Awaiting requested review from dogbert911

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@k-dovgan @miltolstoy @i-keliukh