Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/drivers/input: Add ioctl for Touch Wakeup and suspend #6519

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

namanjain7
Copy link
Contributor

Add support for Touch wakeup and touch suspend. Added ioctl for it

Copy link
Contributor

@sunghan-chang sunghan-chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add location input at the title

os/drivers/input: Add ....

Comment on lines 87 to 88
#define TSIOC_SUSPEND _TSIOC(0x0006) /* Disable touch interrupts */
#define TSIOC_WAKEUP _TSIOC(0x0007) /* Enable touch interrupts */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interrupt

Let's remove s

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@sunghan-chang
Copy link
Contributor

@ewoodev Could you review this?

@namanjain7 namanjain7 changed the title os/: Add ioctl for Touch Wakeup and suspend os/drivers/input: Add ioctl for Touch Wakeup and suspend Nov 22, 2024
Add support for Touch wakeup and touch suspend. Added ioctl for it
Comment on lines +232 to 240
case TSIOC_SUSPEND: {
priv->ops->touch_disable(priv);
}
break;

case TSIOC_WAKEUP: {
priv->ops->touch_enable(priv);
}
break;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry but real operations are touch disable and enable. But the commands are SUSPEND and WAKEUP. wakeup and enable look little bit different. Is it impossible to use ENABLE and DISABLE?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants