Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter configurable arguments in rules config #622

Merged
merged 4 commits into from
Nov 27, 2024
Merged

Filter configurable arguments in rules config #622

merged 4 commits into from
Nov 27, 2024

Conversation

babenek
Copy link
Contributor

@babenek babenek commented Nov 26, 2024 •
edited
Loading

Description

Please include a summary of the change and which is fixed.

  • Add configurable arguments (int,float,str) for filters in rule config
  • Fix AWS Multu rule for some FP cases
  • Add filter for Jira / Confluence PAT token to skip FP when value is a part of base64

How has this been tested?

Please describe the tests that you ran to verify your changes.

  • UnitTest
  • Benchmark

@babenek babenek requested a review from a team as a code owner November 26, 2024 13:15
babenek
babenek commented Nov 26, 2024
View reviewed changes
credsweeper/rules/rule.py Outdated Show resolved Hide resolved
@babenek babenek changed the title Filters configurable arguments in rules config Filter configurable arguments in rules config Nov 27, 2024
Yullia
Yullia approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@Yullia Yullia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@babenek babenek merged commit 46b395f into Samsung:main Nov 27, 2024
27 checks passed
@babenek babenek deleted the awsmulti branch November 27, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yullia Yullia Yullia approved these changes

@xDizzix xDizzix xDizzix approved these changes

@csh519 csh519 Awaiting requested review from csh519

@iuriimet iuriimet Awaiting requested review from iuriimet

@Dmitriy-NK Dmitriy-NK Awaiting requested review from Dmitriy-NK

@kmnls kmnls Awaiting requested review from kmnls

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@babenek @xDizzix @Yullia