Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markup locations for secret values in lines #90

Merged
merged 9 commits into from
Mar 4, 2024
Merged

Markup locations for secret values in lines #90

merged 9 commits into from
Mar 4, 2024

Conversation

Yullia
Copy link
Contributor

@Yullia Yullia commented Mar 1, 2024

Update locations in line for:
API,
Nonce,
Key,
Salt,
Credential,
Auth,
Url Credential

@Yullia Yullia requested a review from a team as a code owner March 1, 2024 09:55
@Yullia Yullia marked this pull request as draft March 1, 2024 10:47
@Yullia Yullia marked this pull request as ready for review March 2, 2024 06:23
babenek
babenek reviewed Mar 2, 2024
View reviewed changes
Copy link
Contributor

@babenek babenek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corrections

meta/cc51a2f0.csv Outdated Show resolved Hide resolved
meta/9128de73.csv Outdated Show resolved Hide resolved
meta/a09d9e50.csv Outdated Show resolved Hide resolved
meta/a09d9e50.csv Outdated Show resolved Hide resolved
meta/a09d9e50.csv Outdated Show resolved Hide resolved
babenek
babenek reviewed Mar 2, 2024
View reviewed changes
Copy link
Contributor

@babenek babenek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 TF

meta/8cda00f3.csv Outdated Show resolved Hide resolved
meta/8cda00f3.csv Outdated Show resolved Hide resolved
babenek
babenek previously approved these changes Mar 2, 2024
View reviewed changes
Copy link
Contributor

@babenek babenek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the pointed markup

babenek
babenek reviewed Mar 2, 2024
View reviewed changes
meta/a09d9e50.csv Outdated Show resolved Hide resolved
@babenek babenek self-requested a review March 2, 2024 07:41
babenek
babenek approved these changes Mar 2, 2024
View reviewed changes
Copy link
Contributor

@babenek babenek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. all corrections are made

kmnls
kmnls approved these changes Mar 4, 2024
View reviewed changes
Copy link

@kmnls kmnls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree

@Yullia Yullia merged commit 60c29b4 into Samsung:main Mar 4, 2024
3 checks passed
@Yullia Yullia deleted the markup_api_key branch March 4, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmnls kmnls kmnls approved these changes

@babenek babenek babenek approved these changes

@xDizzix xDizzix xDizzix approved these changes

@iuriimet iuriimet Awaiting requested review from iuriimet

@csh519 csh519 Awaiting requested review from csh519

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Yullia @xDizzix @babenek @kmnls