[WIP] Support castanets for windows port. #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suyambulingamrm
requested review from
hyowon,
joonghunpark,
yg48,
nke94,
djmixkim,
Chikdolman,
is46-kim,
Sunwoo-Nam,
younghajung,
hyunaranda and
venumusham
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is to support castanets for windows port and still a wip.
If there is any inputs/pointers please let me know.
Current status:
Web page renders fine when we run on standalone and different windows machines. (With --disable-gpu-compositing)
(i) Workaround has been added for font crash (when accessing font on renderer side) by creating new FontManager on renderer.
(ii) Events are not working still.
(iii) 10 ms sleep is added on channel_win.cc after winsoc write, without which incorrect msgs are observed during communication.
(iv) Gpu support is not yet done.