change job name. change clone name convention. fix typos. new delete_…

…clone job.
Sage-Bionetworks · Oct 28, 2024 · ca73fb6 · ca73fb6
1 parent 46c8390
commit ca73fb6
Showing 1 changed file with 11 additions and 6 deletions.
diff --git a/.github/workflows/test_with_clone.yaml b/.github/workflows/test_with_clone.yaml
@@ -9,7 +9,7 @@ permissions:
     contents: read
 
 jobs:
-    test_with_clone:
+    create_clone_and_run_schemachange:
         runs-on: ubuntu-latest
         if: contains(github.event.pull_request.labels.*.name, 'create_clone_and_run_schemachange')
         environment: dev
@@ -20,7 +20,7 @@ jobs:
             SNOWSQL_WAREHOUSE: ${{ secrets.SNOWSQL_WAREHOUSE }}
             SNOWSQL_CLONE_ROLE: DATA_ENGINEER
             #SNOWSQL_SCHEMACHANGE_ROLE: SYSADMIN
-            SNOWFLAKE_SYNAPSE_DATA_WAREHOUSE_DATABASE: "${{ vars.SNOWFLAKE_SYNAPSE_DATA_WAREHOUSE_DATABASE }}_${{ github.sha }}"
+            SNOWFLAKE_SYNAPSE_DATA_WAREHOUSE_DATABASE: "${{ vars.SNOWFLAKE_SYNAPSE_DATA_WAREHOUSE_DATABASE }}_${{ github.head_ref }}"
             SNOWFLAKE_SYNAPSE_DATA_WAREHOUSE_DATABASE_ORIG: ${{ vars.SNOWFLAKE_SYNAPSE_DATA_WAREHOUSE_DATABASE }}
 
 
@@ -49,16 +49,21 @@ jobs:
             - name: Zero-copy clone the database
               shell: bash
               run: |
-                ~/bin/snowsql -r $SNOWSQL_CLONE_ROLE -q "CREATE DATABASE $SNOWFLAKE_SYNAPSE_DATA_WAREHOUSE_DATABASE CLONE $SNOWFLAKE_SYNAPSE_DATA_WAREHOUSE_DATABASE_ORIG;"
+                ~/bin/snowsql -r $SNOWSQL_CLONE_ROLE -q "CREATE OR REPLACE DATABASE $SNOWFLAKE_SYNAPSE_DATA_WAREHOUSE_DATABASE CLONE $SNOWFLAKE_SYNAPSE_DATA_WAREHOUSE_DATABASE_ORIG;"
 
             # TODO: Do we need SYSADMIN to run schemachange?
             - name: Run schemachange on the clone
               shell: bash
               run: |
                 schemachange \
                 -f synapse_data_warehouse \
-                -a $SNOWFLAKE_ACCOUNT \
-                -u $SNOWFLAKE_USER \
+                -a $SNOWSQL_ACCOUNT \
+                -u $SNOWSQL_USER \
                 -r $SNOWSQL_CLONE_ROLE \
-                -w compute_xsmall \
+                -w $SNOWSQL_WAREHOUSE \
                 --config-folder synapse_data_warehouse
+
+    # delete_clone:
+    #   runs-on: ubuntu-latest
+    #     if: contains(github.event.pull_request.labels.*.name, 'create_clone_and_run_schemachange')
+    #     environment: dev