Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Erin-Mounts <[email protected]>
  • Loading branch information
syoung-smallwisdom and Erin-Mounts authored Mar 15, 2023
1 parent 7373c52 commit 1d415bd
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion Sources/JsonModel/PolymorphicSerializer.swift
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public protocol PolymorphicRepresentable : PolymorphicTyped, Decodable {
/// serialization protocols defined in Swift 2.0 where an object could conform to either the
/// `Encodable` protocol or the `Decodable` protocol without conforming to the `Codable`
/// protocol. Additionally, these older objects often had serialization strategies that
/// conflicted with either encoding or decoding. To work-around this, we introduced the
/// conflicted with either encoding or decoding. To work around this, we introduced the
/// `PolymorphicRepresentable` protocol which **only** required adherence to the `Decodable`
/// protocol and not to the `Encodable` protocol. This allowed developers who only needed
/// to decode their objects, to use the ``SerializationFactory`` to handle polymorphic
Expand Down
2 changes: 1 addition & 1 deletion Sources/JsonModel/PolymorphicWrapper.swift
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import Foundation
/// limitations, it is **highly recommended** that you thoroughly unit test your implementations
/// for the expected encoding and decoding of polymorphic objects.
///
/// The simpliest example is a non-null, read/write, required value without a default such as:
/// The simplest example is a non-null, read/write, required value without a default such as:
///
/// ```
/// struct SampleTest : Codable {
Expand Down
2 changes: 1 addition & 1 deletion Tests/JsonModelTests/PolymorphicSerializerTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ final class PolymorphicSerializerTests: XCTestCase {
XCTAssertEqual("a", typeName)
}
else {
XCTFail("Encoding does not include 'valtypeue' keyword. \(dictionary)")
XCTFail("Encoding does not include 'type' keyword. \(dictionary)")
}
}

Expand Down

0 comments on commit 1d415bd

Please sign in to comment.