-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GEN-1109] Setup base mkdocs for genie #566
Conversation
Thanks @rxu17 for your work here! I agree that we don't have to worry about auto generating the R code documentation for now. It'd be great if this was linked to github pages! |
You can see the live site at: https://sage-bionetworks.github.io/Genie/ |
docs/index.md
Outdated
|
||
## Introduction | ||
|
||
This repository documents code used to gather, QC, standardize, and analyze data uploaded by institutes participating in AACR's Project GENIE (Genomics, Evidence, Neoplasia, Information, Exchange). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets link to the portal URL?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rxu17 hmmm, i think its valuable to have the portal URL be linked in as many places as possible. I did think about putting out documentation URL there. I go back and forth, but I suppose people who land on the GENIE github probably want documentation and not the portal.
Thoughts @Chelsea-Na ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, I added it to that intro page
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 LGTM!
Per the weekly main genie check-in today, Chelsea also gave this the green light |
Purpose: This draft PR adds an auto-documentation tool
mkdocs
andmkdocstrings
for the Genie repo, setting up the initial skeleton and base pages for the genie docs. It helps auto-document our codebase as well as allowing us to add custom markdown pages.This PR is just meant to set up the skeleton of the docs so we can get started with documenting our codebase and looking into areas of lacking documentation / improvement, refining specific things like font size, headings, etc will be done in a separate ticket.
Limitations: We will not be able to auto-document our R scripts as there isn't an extension similar to
mkdocstrings
for R. We can use a mix ofroxygen2
andknitr
to convert our R code to Rmarkdown files -> markdown files which can then be rendered in mkdocs. However this way is more hacky. We plan to convert all our R scripts to Python eventually / move the dashboard R scripts to Nextflow module so this may not be a concern.Changes:
Initial vision and structure for the genie docs:
Testing:
In the root directory run
mkdocs serve
to view the live docsExamples: