-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GEN-1067] add functionality to warn for identical ref and tsa2 #553
Conversation
remove extra trailing whitespaces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great first genie PR! I added some comments
Also don't forget to make sure your build is successful, i think there's just some formatting to adjust in your code: If you have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for implementing the changes. Going to pre-approve! Just a couple more comments.
Quality Gate passedIssues Measures |
Purpose:
This PR includes changes in
_check_tsa1_tsa2
function ofmaf.py
to throw errors (column level and row level) when REFERENCE_ALLELE is equal to TUMOR_SEQ_ALLELE2.Test: