[GEN-1078] HOTFIX: Add in new known string columns as MSK added new columns into maf file #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasyu888
changed the title
|
Chelsea-Na
approved these changes
Jan 16, 2024
There was a problem hiding this comment.
If possible we should probably explore how we can ignore casing on column headers when we’re reading in the data frame (or an alternative solution) so we don’t face the “transcription” or “TRANSCRIPTION” issue.
We should also discuss if it is possible to only read in specific columns when reading in the data frame in pandas.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR is being merged into main to enable processing.
Problem
The first 5000 rows of file do not always contain the correct dtype
Solution
Set the known string columns to be string type so that the code doesn't try to convert string to integer