Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GEN-1026] Output annotation error report #544

Merged
merged 6 commits into from
Jan 11, 2024
Merged

Conversation

rxu17
Copy link
Contributor

@rxu17 rxu17 commented Jan 5, 2024

Purpose: Part of the ticket to allow for the output of the annotation error report.
This will add the new annotation-tools tag (once the annotation-tools PR gets merged and a new tag gets created) and the required java 11 update to the docker image in order to support the new annotator.jar file used as part of the GEN-1026 update.

Testing:
Rebuilt docker container in ec2 instance and ran the process mutation files. Files ran successfully.

Depends on annotation-tools PR #8

@rxu17 rxu17 requested a review from a team as a code owner January 5, 2024 21:44
Copy link
Member

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 LGTM!

)
# Genome Nexus Jar file
syn.get(
"syn22084320",
ifcollision="overwrite.local",
downloadLocation=genie_config["genie_annotation_pkg"],
version=13, # TODO: This should pull from a config file in the future
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rxu17 I'd comment this out for now and just rely on the latest version until we are actually able to pull this from a config file.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

E Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@rxu17 rxu17 merged commit 09fd450 into develop Jan 11, 2024
7 of 8 checks passed
@rxu17 rxu17 deleted the gen-1026-output-error branch January 11, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants