-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GEN-1026] Output annotation error report #544
Conversation
…n on annotation-tools
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 LGTM!
genie/process_mutation.py
Outdated
) | ||
# Genome Nexus Jar file | ||
syn.get( | ||
"syn22084320", | ||
ifcollision="overwrite.local", | ||
downloadLocation=genie_config["genie_annotation_pkg"], | ||
version=13, # TODO: This should pull from a config file in the future |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rxu17 I'd comment this out for now and just rely on the latest version until we are actually able to pull this from a config file.
Quality Gate failedFailed conditions E Maintainability Rating on New Code (required ≥ A) See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Purpose: Part of the ticket to allow for the output of the annotation error report.
This will add the new annotation-tools tag (once the annotation-tools PR gets merged and a new tag gets created) and the required java 11 update to the docker image in order to support the new
annotator.jar
file used as part of the GEN-1026 update.Testing:
Rebuilt docker container in ec2 instance and ran the process mutation files. Files ran successfully.
Depends on annotation-tools PR #8